Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2584813002: arc: Launch Kiosk app immediately after installation. (Closed)

Created:
4 years ago by Sergey Poromov
Modified:
4 years ago
Reviewers:
xiyuan, Nikita (slow)
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Launch Kiosk app immediately after installation. When Kiosk app is just installed from Play, "OnAppRegistered()" is called, but ArcKioskAppService didn't know about Kiosk app id. Now it retrieves app id if not know yet. BUG=674776 Committed: https://crrev.com/c93d70a58ecf62a86051e4a1549dd26bd62d0bf6 Cr-Commit-Position: refs/heads/master@{#439495}

Patch Set 1 #

Patch Set 2 : Populate app_id always when preconditions change. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc View 1 3 chunks +5 lines, -7 lines 1 comment Download

Messages

Total messages: 15 (9 generated)
Sergey Poromov
Please review small fix for http://crbug.com/674776 in: chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc This is going to be merged in ...
4 years ago (2016-12-16 11:13:14 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/2584813002/diff/20001/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc File chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc (right): https://codereview.chromium.org/2584813002/diff/20001/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc#newcode91 chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc:91: app_id_ = GetAppId(); nit: doesn't look you still ...
4 years ago (2016-12-19 16:48:18 UTC) #7
Nikita (slow)
lgtm lgtm
4 years ago (2016-12-19 16:48:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584813002/20001
4 years ago (2016-12-19 17:08:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 17:33:39 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 17:36:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c93d70a58ecf62a86051e4a1549dd26bd62d0bf6
Cr-Commit-Position: refs/heads/master@{#439495}

Powered by Google App Engine
This is Rietveld 408576698