Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2584783002: DevTools: Add "New" button to launch timeline landing page. (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add "New" button to launch timeline landing page. BUG=570441 Committed: https://crrev.com/614625d8efb5e0d969541e2a9e94d7b210488417 Cr-Commit-Position: refs/heads/master@{#439069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 4 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
alph
4 years ago (2016-12-16 02:32:12 UTC) #2
pfeldman
lgtm
4 years ago (2016-12-16 02:33:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584783002/1
4 years ago (2016-12-16 04:24:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/124120) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-16 04:27:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584783002/1
4 years ago (2016-12-16 05:59:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 08:43:12 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 08:45:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/614625d8efb5e0d969541e2a9e94d7b210488417
Cr-Commit-Position: refs/heads/master@{#439069}

Powered by Google App Engine
This is Rietveld 408576698