Set fields before calling ActionMode.invalidate()

Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old values
of those fields which is incorrect. This fix could reduce flakiness in the scenario
where the IME thread updates after the action mode is created.

BUG=592428
Committed: https://crrev.com/fa17096f47dcc992185f1a09de28034f17d33b5d
Cr-Commit-Position: refs/heads/master@{#439291}

[amaralp, 2016-12-16 01:38:11]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 01:38:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:57:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[amaralp, 2016-12-16 21:20:01]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 21:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 22:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 22:29:02]

Dry run: This issue passed the CQ dry run.

[amaralp, 2016-12-16 22:29:41]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org

[amaralp, 2016-12-16 22:31:37]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously setting the fields after calling could cause a race condition
where SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate(). This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

[amaralp, 2016-12-16 22:31:58]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate(). This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

[amaralp, 2016-12-16 22:32:24]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

[amaralp, 2016-12-16 22:32:35]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

[amaralp, 2016-12-16 22:32:56]

PTAL

[aelias_OOO_until_Jul13, 2016-12-16 22:48:42]

It sounds like you observed a bug, could you file a crbug for it and link it
with BUG=?

[amaralp, 2016-12-16 22:52:02]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.

BUG=592428
==========

[amaralp, 2016-12-16 22:52:45]

On 2016/12/16 at 22:48:42, aelias wrote:
> It sounds like you observed a bug, could you file a crbug for it and link it
with BUG=?

I haven't actually traced a bug to this. It just has the potential to cause one.
I've linked it to the flaky selection tests bug.

[aelias_OOO_until_Jul13, 2016-12-16 23:03:31]

I don't think there can be a race here.  If the callback is called
synchronously, it would consistently fail (so it's not); if it's posted
asychronously on the UI-thread message loop, the message loop needs to be
yielded before it's run.  The race you're imagining could only happen if the
callback was posted on a side thread.

[aelias_OOO_until_Jul13, 2016-12-17 01:33:47]

After offline discussion, ou confirmed this is synchronous and this is just a
rarely seen corner case, so lgtm.

[amaralp, 2016-12-17 02:01:09]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2016-12-17 02:02:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2016-12-17 02:03:13]

The CQ bit was unchecked by amaralp@chromium.org

[amaralp, 2016-12-17 02:11:14]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This could cause a race condition where
SelectionPopupController.onPrepareActionMode() is called before
mEditable/mIsPasswordType/mNeedsPrepare are set.

BUG=592428
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect.

BUG=
==========

[amaralp, 2016-12-17 02:20:59]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect.

BUG=
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario where the IME thread updates after the action mode is created.

BUG=592428
==========

[amaralp, 2016-12-17 02:21:08]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario where the IME thread updates after the action mode is created.

BUG=592428
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario
where the IME thread updates after the action mode is created.

BUG=592428
==========

[amaralp, 2016-12-17 02:21:18]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2016-12-17 02:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 02:28:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481941278110680,
"parent_rev": "111abe4ad44be0890d5bc67d9a22cd18dcb82bc6", "commit_rev":
"d27427881507b16a5ddd72a886bd18bb4ac07034"}

[commit-bot: I haz the power, 2016-12-17 02:29:21]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario
where the IME thread updates after the action mode is created.

BUG=592428
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario
where the IME thread updates after the action mode is created.

BUG=592428

Review-Url: https://codereview.chromium.org/2584773002
==========

[commit-bot: I haz the power, 2016-12-17 02:29:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-17 02:31:43]

Description was changed from

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario
where the IME thread updates after the action mode is created.

BUG=592428

Review-Url: https://codereview.chromium.org/2584773002
==========

to

==========
Set fields before calling ActionMode.invalidate()

Previously mEditable/mIsPassword/mNeedsPrepare were set after calling
invalidate().
This means that SelectionPopupController.onPrepareActionMode() sees the old
values
of those fields which is incorrect. This fix could reduce flakiness in the
scenario
where the IME thread updates after the action mode is created.

BUG=592428

Committed: https://crrev.com/fa17096f47dcc992185f1a09de28034f17d33b5d
Cr-Commit-Position: refs/heads/master@{#439291}
==========

[commit-bot: I haz the power, 2016-12-17 02:31:44]

Patchset 2 (id:??) landed as
https://crrev.com/fa17096f47dcc992185f1a09de28034f17d33b5d
Cr-Commit-Position: refs/heads/master@{#439291}