Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2584733003: Remove performanceMonitor()->unsubscribeAll() from Performance's destructor (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove performanceMonitor()->unsubscribeAll() from Performance's destructor Performance object is on Oilpan's heap, so its destructor is not allowed to touch other on-heap objects. Also we don't need to call performanceMonitor()->unsubscribeAll() because it is just unregistering a back pointer Member to the Performance object from the map in PerformanceMonitor. BUG= Committed: https://crrev.com/18502d9c2a5ec6c54e8f7cd2a11bb2e45e78e331 Cr-Commit-Position: refs/heads/master@{#439081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/timing/Performance.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
4 years ago (2016-12-16 02:57:46 UTC) #2
sof
lgtm
4 years ago (2016-12-16 07:36:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584733003/1
4 years ago (2016-12-16 07:40:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 10:01:08 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 10:03:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18502d9c2a5ec6c54e8f7cd2a11bb2e45e78e331
Cr-Commit-Position: refs/heads/master@{#439081}

Powered by Google App Engine
This is Rietveld 408576698