Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2584723005: Add information for checking in large files in adding_to_third_party.md (Closed)

Created:
4 years ago by F
Modified:
4 years ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add information for checking in large files in adding_to_third_party.md BUG=674221 Committed: https://crrev.com/2d0d3d8d5ba17f988ab4b61364b7f7f66c5b0f9e Cr-Commit-Position: refs/heads/master@{#439199}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix internal link with goto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M docs/adding_to_third_party.md View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
F
Hi Andrew, PTAL. Thanks!
4 years ago (2016-12-16 20:24:16 UTC) #2
agrieve
https://codereview.chromium.org/2584723005/diff/1/docs/adding_to_third_party.md File docs/adding_to_third_party.md (right): https://codereview.chromium.org/2584723005/diff/1/docs/adding_to_third_party.md#newcode110 docs/adding_to_third_party.md:110: See [Moving large files to Google Storage](https://sites.google.com/a/google.com/chrome-infrastructure/platform/git-conversion/moving-large-files-to-google-storage?pli=1) nit: wrap ...
4 years ago (2016-12-16 20:29:01 UTC) #3
F
Thanks Andrew! PTAL https://codereview.chromium.org/2584723005/diff/1/docs/adding_to_third_party.md File docs/adding_to_third_party.md (right): https://codereview.chromium.org/2584723005/diff/1/docs/adding_to_third_party.md#newcode110 docs/adding_to_third_party.md:110: See [Moving large files to Google ...
4 years ago (2016-12-16 21:28:42 UTC) #4
agrieve
On 2016/12/16 21:28:42, F wrote: > Thanks Andrew! PTAL > > https://codereview.chromium.org/2584723005/diff/1/docs/adding_to_third_party.md > File docs/adding_to_third_party.md ...
4 years ago (2016-12-16 21:30:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584723005/20001
4 years ago (2016-12-16 21:34:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 21:48:53 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 21:50:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d0d3d8d5ba17f988ab4b61364b7f7f66c5b0f9e
Cr-Commit-Position: refs/heads/master@{#439199}

Powered by Google App Engine
This is Rietveld 408576698