Move ongot/lostpointercaptures to global handlers

Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUSoAzHA

BUG=674290
Committed: https://crrev.com/3f26be51899994fee914cb9be4076a62d168ee31
Cr-Commit-Position: refs/heads/master@{#439857}

[Navid Zolghadr, 2016-12-16 17:27:09]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[Navid Zolghadr, 2016-12-16 17:27:29]

Description was changed from

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

BUG=674290
==========

to

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

BUG=674290
==========

[Navid Zolghadr, 2016-12-16 17:27:54]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-12-16 17:34:44]

And here is the test in case you'd like to review the CL with the tests:
https://github.com/w3c/web-platform-tests/pull/4357

[dtapuska, 2016-12-16 17:50:16]

On 2016/12/16 17:34:44, Navid Zolghadr wrote:
> And here is the test in case you'd like to review the CL with the tests:
> https://github.com/w3c/web-platform-tests/pull/4357

I think you'll need to update webexposed no?

[dtapuska, 2016-12-16 17:50:44]

lgtm % fixing layout tests and landing the web platform test.

[commit-bot: I haz the power, 2016-12-16 19:23:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:23:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2016-12-16 20:38:18]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 20:39:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-12-16 20:42:44]

nzolghadr@chromium.org changed reviewers:
+ rbyers@chromium.org

[Navid Zolghadr, 2016-12-16 20:42:45]

rbyers@chromium.org: Please review changes in 

third_party/WebKit/*

[Rick Byers, 2016-12-16 20:51:26]

Changes look good but even though it's trivial this is technically a "new API"
so I think we need an intent to ship (there are ways this could break sites -
though it seems unlikely to me).

All the test coverage here will come from web-platform-tests.  Maybe point to
those WPT commits in the CL description (presumably we'll import and ensure
they're passing separately for now?).

https://codereview.chromium.org/2584723004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
(left):

https://codereview.chromium.org/2584723004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:3537:
getter bluetooth
This shouldn't be removed.  Unfortunately there's now platform-specific
expectation files - you'll probably need to update by hand to get things passing
on all platforms (there's a thread somewhere on making this simpler).

[commit-bot: I haz the power, 2016-12-16 22:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 22:34:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Navid Zolghadr, 2016-12-19 18:06:54]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 18:07:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:44:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2016-12-19 20:53:32]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 20:54:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 22:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 22:24:50]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2016-12-20 01:10:40]

ptal.

[mustaq, 2016-12-20 15:17:44]

lgtm

Please add a link to the intent thread in the description.

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.idl (right):

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.idl:40:
//https://www.w3.org/TR/pointerevents/#extensions-to-the-element-interface
Let's replace this link with the v2 spec link (and merge the following para). We
are no longer following the Feb 2015 spec here.

[Navid Zolghadr, 2016-12-20 15:27:50]

Description was changed from

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

BUG=674290
==========

to

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUS...

BUG=674290
==========

[Navid Zolghadr, 2016-12-20 15:27:58]

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.idl (right):

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.idl:40:
//https://www.w3.org/TR/pointerevents/#extensions-to-the-element-interface
On 2016/12/20 15:17:44, mustaq wrote:
> Let's replace this link with the v2 spec link (and merge the following para).
We
> are no longer following the Feb 2015 spec here.

But v2 spec does have the ongot/lostpointercapture attributes here too. So if we
really like to be correct here we should use the draft link. Having said that
which one is better? draft or v2? I assume you want me to use the same in
globaleventhandlers.idl as well. Right?

[Rick Byers, 2016-12-20 15:37:12]

LGTM with nit

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.idl (right):

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.idl:40:
//https://www.w3.org/TR/pointerevents/#extensions-to-the-element-interface
On 2016/12/20 15:27:57, Navid Zolghadr wrote:
> On 2016/12/20 15:17:44, mustaq wrote:
> > Let's replace this link with the v2 spec link (and merge the following
para).
> We
> > are no longer following the Feb 2015 spec here.
> 
> But v2 spec does have the ongot/lostpointercapture attributes here too. So if
we
> really like to be correct here we should use the draft link. Having said that
> which one is better? draft or v2? I assume you want me to use the same in
> globaleventhandlers.idl as well. Right?

In general we prefer links to live spec versions.  We (markdittmer, lunalu,
foolip) are working on tooling that uses these links to automatically detect
spec mismatches.  I think we've been doing some bulk updates to w3c.github.io
links, so this should be updated to that as well.

[Navid Zolghadr, 2016-12-20 17:02:36]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 17:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-12-20 17:04:44]

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.idl (right):

https://codereview.chromium.org/2584723004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.idl:40:
//https://www.w3.org/TR/pointerevents/#extensions-to-the-element-interface
On 2016/12/20 15:37:12, Rick Byers wrote:
> On 2016/12/20 15:27:57, Navid Zolghadr wrote:
> > On 2016/12/20 15:17:44, mustaq wrote:
> > > Let's replace this link with the v2 spec link (and merge the following
> para).
> > We
> > > are no longer following the Feb 2015 spec here.
> > 
> > But v2 spec does have the ongot/lostpointercapture attributes here too. So
if
> we
> > really like to be correct here we should use the draft link. Having said
that
> > which one is better? draft or v2? I assume you want me to use the same in
> > globaleventhandlers.idl as well. Right?
> 
> In general we prefer links to live spec versions.  We (markdittmer, lunalu,
> foolip) are working on tooling that uses these links to automatically detect
> spec mismatches.  I think we've been doing some bulk updates to w3c.github.io
> links, so this should be updated to that as well.

Done.

[Navid Zolghadr, 2016-12-20 17:04:54]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-12-20 17:04:56]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-12-20 17:04:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, mustaq@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2584723004/#ps80001
(title: "Fix the link to the spec")

[Navid Zolghadr, 2016-12-20 17:05:02]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-12-20 17:05:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 18:53:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482253502394270,
"parent_rev": "5ddae1dad9a83e5f63ce7eeb0b1798b4a12337ed", "commit_rev":
"385104afe3cd48dbc20d58ee5f1f5c15d9adcf76"}

[commit-bot: I haz the power, 2016-12-20 18:54:16]

Description was changed from

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUS...

BUG=674290
==========

to

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUS...

BUG=674290

Review-Url: https://codereview.chromium.org/2584723004
==========

[commit-bot: I haz the power, 2016-12-20 18:54:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-20 18:57:25]

Description was changed from

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUS...

BUG=674290

Review-Url: https://codereview.chromium.org/2584723004
==========

to

==========
Move ongot/lostpointercaptures to Global handlers

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUS...

BUG=674290

Committed: https://crrev.com/3f26be51899994fee914cb9be4076a62d168ee31
Cr-Commit-Position: refs/heads/master@{#439857}
==========

[commit-bot: I haz the power, 2016-12-20 18:57:26]

Patchset 5 (id:??) landed as
https://crrev.com/3f26be51899994fee914cb9be4076a62d168ee31
Cr-Commit-Position: refs/heads/master@{#439857}