Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2584663002:
swarming: send task tags to event_mon (Closed)
|
Created:
4 years ago by Paweł Hajdan Jr. Modified:
4 years ago Reviewers:
M-A Ruel CC:
chromium-reviews, infra-reviews+luci-py_chromium.org Target Ref:
refs/heads/master Project:
luci-py Visibility:
Public. |
Descriptionswarming: send task tags to event_mon
BUG=660014
Review-Url: https://codereview.chromium.org/2584663002
Committed: https://github.com/luci/luci-py/commit/0ed8407e43d4e67200fd4b5aa4f014c0d8809065
Patch Set 1 #
Total comments: 2
Patch Set 2 : fixes #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
phajdan.jr@chromium.org changed reviewers: + maruel@chromium.org
lgtm with fix fixes https://codereview.chromium.org/2584663002/diff/1/appengine/swarming/event_mo... File appengine/swarming/event_mon_metrics.py (right): https://codereview.chromium.org/2584663002/diff/1/appengine/swarming/event_mo... appengine/swarming/event_mon_metrics.py:29: 'build_id', buildnumber ? https://codereview.chromium.org/2584663002/diff/1/appengine/swarming/event_mo... appengine/swarming/event_mon_metrics.py:31: 'codereview', For Rietveld triggered task, it's 'rietveld'
The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Done.
lgtm
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481919096826220,
"parent_rev": "30c63a8c03d68ec21a744f79bd29e01474159014", "commit_rev":
"0ed8407e43d4e67200fd4b5aa4f014c0d8809065"}
Message was sent while issue was closed.
Description was changed from ========== swarming: send task tags to event_mon BUG=660014 ========== to ========== swarming: send task tags to event_mon BUG=660014 Review-Url: https://codereview.chromium.org/2584663002 Committed: https://github.com/luci/luci-py/commit/0ed8407e43d4e67200fd4b5aa4f014c0d8809065 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/0ed8407e43d4e67200fd4b5aa4f014c0d8809065 |
