Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2584633002: Reenables (and fixs) two mash tests (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenables (and fixs) two mash tests These were disabled because of issues with the allocator shim. That's been fixed, so they can be reenabled again. BUG=642879 TEST=test only changes R=msw@chromium.org Committed: https://crrev.com/c09cf5f93bd8926d3f3b8202c820e57b6e319b79 Cr-Commit-Position: refs/heads/master@{#438884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M ash/mus/app_launch_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ash/mus/window_manager_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
4 years ago (2016-12-15 18:24:18 UTC) #1
msw
lgtm
4 years ago (2016-12-15 18:49:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584633002/1
4 years ago (2016-12-15 18:50:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 18:58:00 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 19:02:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c09cf5f93bd8926d3f3b8202c820e57b6e319b79
Cr-Commit-Position: refs/heads/master@{#438884}

Powered by Google App Engine
This is Rietveld 408576698