[wasm] TrapIf and TrapUnless TurboFan operators implemented on arm.

[wasm] TrapIf and TrapUnless TurboFan operators implemented on arm.

Original commit message:
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code.

Some instructions in WebAssembly trap for some inputs, which means that the
execution is terminated and (at least at the moment) a JavaScript exception is
thrown. Examples for traps are out-of-bounds memory accesses, or integer
divisions by zero.

Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces 5
TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position
constant), in addition to the trap condition itself. Additionally, each
WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose
number of inputs is linear to the number of trap checks in the function.
Especially for functions with high numbers of trap checks we observe a
significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite
benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing
a TrapIf common operator only a single node is necessary per trap check, in
addition to the trap condition. Also the nodes which are shared between trap
checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a
speedup of 30-50% on average.

This CL only implements TrapIf and TrapUnless on x64. The implementation is also
hidden behind the --wasm-trap-if flag.

Please take a special look at how the source position is transfered from the
instruction selector to the code generator, and at the context that is used for
the runtime call.

R=titzer@chromium.org, v8-arm-ports@googlegroups.com

Review-Url: https://codereview.chromium.org/2584603002
Cr-Commit-Position: refs/heads/master@{#41774}
Committed: https://chromium.googlesource.com/v8/v8/+/ca8d3ba7183d2b7a9691b2e732f7dbe8dc719a3e

[ahaas, 2016-12-15 15:20:24]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 15:20:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 15:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:49:02]

Dry run: This issue passed the CQ dry run.

[georgia.kouveli, 2016-12-15 16:39:35]

georgia.kouveli@arm.com changed reviewers:
+ georgia.kouveli@arm.com

[georgia.kouveli, 2016-12-15 16:39:35]

Just a very minor comment.

https://codereview.chromium.org/2584603002/diff/1/src/compiler/arm/instructio...
File src/compiler/arm/instruction-selector-arm.cc (right):

https://codereview.chromium.org/2584603002/diff/1/src/compiler/arm/instructio...
src/compiler/arm/instruction-selector-arm.cc:1267: DCHECK(cont->IsSet());
You've missed a couple of redundant DCHECKs here and in VisitWordCompareZero.

[ahaas, 2016-12-15 16:57:36]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 16:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-12-15 16:57:59]

https://codereview.chromium.org/2584603002/diff/1/src/compiler/arm/instructio...
File src/compiler/arm/instruction-selector-arm.cc (right):

https://codereview.chromium.org/2584603002/diff/1/src/compiler/arm/instructio...
src/compiler/arm/instruction-selector-arm.cc:1267: DCHECK(cont->IsSet());
On 2016/12/15 at 16:39:35, georgia.kouveli wrote:
> You've missed a couple of redundant DCHECKs here and in VisitWordCompareZero.

Done.

[commit-bot: I haz the power, 2016-12-15 17:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:26:55]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-16 09:08:16]

On 2016/12/15 16:57:59, ahaas wrote:
>
https://codereview.chromium.org/2584603002/diff/1/src/compiler/arm/instructio...
> File src/compiler/arm/instruction-selector-arm.cc (right):
> 
>
https://codereview.chromium.org/2584603002/diff/1/src/compiler/arm/instructio...
> src/compiler/arm/instruction-selector-arm.cc:1267: DCHECK(cont->IsSet());
> On 2016/12/15 at 16:39:35, georgia.kouveli wrote:
> > You've missed a couple of redundant DCHECKs here and in
VisitWordCompareZero.
> 
> Done.

lgtm

[ahaas, 2016-12-16 16:46:26]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-12-16 16:46:26]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2584603002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-16 16:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:16:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481906786339070,
"parent_rev": "7bdb906946b94e9ba10de13e104a39bbcabedbd6", "commit_rev":
"ca8d3ba7183d2b7a9691b2e732f7dbe8dc719a3e"}

[commit-bot: I haz the power, 2016-12-16 17:16:50]

Description was changed from

==========
[wasm] TrapIf and TrapUnless TurboFan operators implemented on arm.

Original commit message:
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code.

Some instructions in WebAssembly trap for some inputs, which means that the
execution is terminated and (at least at the moment) a JavaScript exception is
thrown. Examples for traps are out-of-bounds memory accesses, or integer
divisions by zero.

Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces
5
TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position
constant), in addition to the trap condition itself. Additionally, each
WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose
number of inputs is linear to the number of trap checks in the function.
Especially for functions with high numbers of trap checks we observe a
significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite
benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing
a TrapIf common operator only a single node is necessary per trap check, in
addition to the trap condition. Also the nodes which are shared between trap
checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a
speedup of 30-50% on average.

This CL only implements TrapIf and TrapUnless on x64. The implementation is also
hidden behind the --wasm-trap-if flag.

Please take a special look at how the source position is transfered from the
instruction selector to the code generator, and at the context that is used for
the runtime call.

R=titzer@chromium.org, v8-arm-ports@googlegroups.com
==========

to

==========
[wasm] TrapIf and TrapUnless TurboFan operators implemented on arm.

Original commit message:
[wasm] Introduce the TrapIf and TrapUnless operators to generate trap code.

Some instructions in WebAssembly trap for some inputs, which means that the
execution is terminated and (at least at the moment) a JavaScript exception is
thrown. Examples for traps are out-of-bounds memory accesses, or integer
divisions by zero.

Without the TrapIf and TrapUnless operators trap check in WebAssembly introduces
5
TurboFan nodes (branch, if_true, if_false, trap-reason constant, trap-position
constant), in addition to the trap condition itself. Additionally, each
WebAssembly function has four TurboFan nodes (merge, effect_phi, 2 phis) whose
number of inputs is linear to the number of trap checks in the function.
Especially for functions with high numbers of trap checks we observe a
significant slowdown in compilation time, down to 0.22 MiB/s in the sqlite
benchmark instead of the average of 3 MiB/s in other benchmarks. By introducing
a TrapIf common operator only a single node is necessary per trap check, in
addition to the trap condition. Also the nodes which are shared between trap
checks (merge, effect_phi, 2 phis) would disappear. First measurements suggest a
speedup of 30-50% on average.

This CL only implements TrapIf and TrapUnless on x64. The implementation is also
hidden behind the --wasm-trap-if flag.

Please take a special look at how the source position is transfered from the
instruction selector to the code generator, and at the context that is used for
the runtime call.

R=titzer@chromium.org, v8-arm-ports@googlegroups.com

Review-Url: https://codereview.chromium.org/2584603002
Cr-Commit-Position: refs/heads/master@{#41774}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca8d3ba7183d2b7a9691b2e732f7dbe8dc7...
==========

[commit-bot: I haz the power, 2016-12-16 17:16:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ca8d3ba7183d2b7a9691b2e732f7dbe8dc7...