Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2584523002: [release] Make release scripts work without gnumbd (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release] Make release scripts work without gnumbd This splits branch ref creation and landing. The ref now directly uses heads (without pending) and for landing we use depot_tools. For simplicity, the check for existing tags is removed, as it now is very unlikely to happen again without gnumbd. BUG=chromium:674448 NOTRY=true TBR=tandrii@chromium.org Review-Url: https://codereview.chromium.org/2584523002 Cr-Commit-Position: refs/heads/master@{#41716} Committed: https://chromium.googlesource.com/v8/v8/+/7c43fcb285dc3a009e4116831f8ab3d8433cde52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -46 lines) Patch
M tools/release/create_release.py View 4 chunks +15 lines, -35 lines 0 comments Download
M tools/release/test_scripts.py View 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Achenbach
PTAL
4 years ago (2016-12-15 11:28:01 UTC) #4
tandrii(chromium)
lgtm
4 years ago (2016-12-15 11:32:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584523002/1
4 years ago (2016-12-15 11:47:24 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 11:49:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7c43fcb285dc3a009e4116831f8ab3d8433...

Powered by Google App Engine
This is Rietveld 408576698