content/browser/frame_host/navigation_handle_impl.cc - Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)

Patch Set: Addressed comment (@nasko) #2. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index 44547e2d710872c02b28a3776ec47843c9e9487f..bd6818cd9752edca2ef32458313c4a0e2ff8baf2 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -560,7 +560,7 @@ void NavigationHandleImpl::ReadyToCommitNavigation(

render_frame_host_ = render_frame_host;

state_ = READY_TO_COMMIT;

- if (!IsRendererDebugURL(url_))

+ if (!IsRendererDebugURL(url_) && !IsSamePage())

GetDelegate()->ReadyToCommitNavigation(this);

}