Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 2584513003: PlzNavigate: identify same-page browser-initiated navigation. (Closed)
Patch Set: Addressed comment (@nasko) #2. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl_browsertest.cc
diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc
index dd92b7bb0b732ba92b2e9c7be9c271c239a54aa6..91dcc970715d8ec7360ab05995bc6a7f0e78bb4f 100644
--- a/content/renderer/render_frame_impl_browsertest.cc
+++ b/content/renderer/render_frame_impl_browsertest.cc
@@ -342,6 +342,7 @@ TEST_F(RenderFrameImplTest, ZoomLimit) {
// properly set when it is out of the default zoom limits of WebView.
CommonNavigationParams common_params;
common_params.url = GURL("data:text/html,min_zoomlimit_test");
+ common_params.navigation_type = FrameMsg_Navigate_Type::DIFFERENT_DOCUMENT;
nasko 2017/01/24 16:59:36 Since DIFFERENT_DOCUMENT is the default value, thi
arthursonzogni 2017/01/25 13:13:59 Yes! This isn't strictly necessary. I just wanted
GetMainRenderFrame()->SetHostZoomLevel(common_params.url, kMinZoomLevel);
GetMainRenderFrame()->NavigateInternal(
common_params, StartNavigationParams(), RequestNavigationParams(),

Powered by Google App Engine
This is Rietveld 408576698