Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2584513002:
gpu: Don't destroy the ui::PlatformEventSource too early (Closed)
Descriptiongpu: Don't destroy the ui::PlatformEventSource too early
This patch fixes a bug introduced by r438239 where the
ui::PlatformEventSource was destroyed before entering the GPU message
loop.
BUG=674350
Committed: https://crrev.com/82befc59e91e2befbe289ea85b5f35fc9f6505e1
Cr-Commit-Position: refs/heads/master@{#439465}
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by skyostil@chromium.org to run a CQ dry run
Description was changed from ========== gpu: Don't destroy the ui::PlatformEventSource too early This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 ========== to ========== gpu: Don't destroy the ui::PlatformEventSource too early This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 ==========
skyostil@chromium.org changed reviewers: + zmo@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
skyostil@chromium.org changed reviewers: + jochen@chromium.org
Thanks! Looks like I misread the owners file :) -- Jochen could you stamp pls?
lgtm
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482150838164500, "parent_rev":
"64debdb19b88a11c9a36d3415f4f4eebae15fcd8", "commit_rev":
"3732584dcdf3e1a224a107539cde25812d7da853"}
Message was sent while issue was closed.
Description was changed from ========== gpu: Don't destroy the ui::PlatformEventSource too early This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 ========== to ========== gpu: Don't destroy the ui::PlatformEventSource too early This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 Review-Url: https://codereview.chromium.org/2584513002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== gpu: Don't destroy the ui::PlatformEventSource too early This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 Review-Url: https://codereview.chromium.org/2584513002 ========== to ========== gpu: Don't destroy the ui::PlatformEventSource too early This patch fixes a bug introduced by r438239 where the ui::PlatformEventSource was destroyed before entering the GPU message loop. BUG=674350 Committed: https://crrev.com/82befc59e91e2befbe289ea85b5f35fc9f6505e1 Cr-Commit-Position: refs/heads/master@{#439465} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/82befc59e91e2befbe289ea85b5f35fc9f6505e1 Cr-Commit-Position: refs/heads/master@{#439465} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
