Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2584503002: Clean up ContentSubresourceFilterDriverFactory. (Closed)

Created:
4 years ago by pkalinnikov
Modified:
4 years ago
Reviewers:
melandory
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ContentSubresourceFilterDriverFactory. BUG=609747 Committed: https://crrev.com/6483d5900b8290c04be176aaf6d1bd4455004fc2 Cr-Commit-Position: refs/heads/master@{#438807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pkalinnikov
PTAL.
4 years ago (2016-12-15 10:49:53 UTC) #2
melandory
On 2016/12/15 10:49:53, pkalinnikov wrote: > PTAL. lgtm
4 years ago (2016-12-15 10:51:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584503002/1
4 years ago (2016-12-15 10:51:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 11:51:20 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 11:53:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6483d5900b8290c04be176aaf6d1bd4455004fc2
Cr-Commit-Position: refs/heads/master@{#438807}

Powered by Google App Engine
This is Rietveld 408576698