Merge setTimeout calls with same timeout for webfont tests.

Merge setTimeout calls with same timeout for webfont tests.

Landing async stylesheet update caused a regression in font-display
tests. The values "fallback" and "optional" block display for 100ms
according to the spec. The tests had a setTimeout call to trigger font
loading and a setTimeout call to trigger notifyDone() to render before
100ms has passed with the same timeout value. However, the timer for
allowing fallback display triggers before the notifyDone triggers in
Debug builds on Mac. Calling notifyDone from the same setTimeout
callback as triggering font loading.

The intention of the test is to trigger the screen dump when 0s has
passed, so this should be OK. I have not identified what exactly changed
with the async stylesheet patch and why the timeout methods are
interleaved with the timeout for enabling fallback rendering.

Removing one of the other tests or one of the font-display values from
the test array also makes the "fallback" and "optional" start passing
without this change, so there is clearly a timing issue here.

BUG=567021
Committed: https://crrev.com/ad541b1bdc92608984093593d9eb864ad51ed1e6
Cr-Commit-Position: refs/heads/master@{#439026}

[rune, 2016-12-15 09:56:29]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 09:56:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-12-15 09:58:42]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, ksakamoto@chromium.org

[rune, 2016-12-15 09:58:42]

ptal

[commit-bot: I haz the power, 2016-12-15 12:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 12:26:02]

Dry run: This issue passed the CQ dry run.

[Kunihiko Sakamoto, 2016-12-16 02:36:01]

lgtm

interesting...

[esprehn, 2016-12-16 03:38:22]

Interesting indeed! I wonder if there's an actual race in the system here we
should fix. Maybe something should be more connected to the lifecycle.

lgtm

[esprehn, 2016-12-16 03:48:36]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:49:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:52:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481860116882930, "parent_rev":
"b193fc9d0f93c81663cf6575314cb10424bf1aaf", "commit_rev":
"54a9d1ee23facff721ce53f05b9b3394fd2413c9"}

[commit-bot: I haz the power, 2016-12-16 04:53:06]

Description was changed from

==========
Merge setTimeout calls with same timeout for webfont tests.

Landing async stylesheet update caused a regression in font-display
tests. The values "fallback" and "optional" block display for 100ms
according to the spec. The tests had a setTimeout call to trigger font
loading and a setTimeout call to trigger notifyDone() to render before
100ms has passed with the same timeout value. However, the timer for
allowing fallback display triggers before the notifyDone triggers in
Debug builds on Mac. Calling notifyDone from the same setTimeout
callback as triggering font loading.

The intention of the test is to trigger the screen dump when 0s has
passed, so this should be OK. I have not identified what exactly changed
with the async stylesheet patch and why the timeout methods are
interleaved with the timeout for enabling fallback rendering.

Removing one of the other tests or one of the font-display values from
the test array also makes the "fallback" and "optional" start passing
without this change, so there is clearly a timing issue here.

BUG=567021
==========

to

==========
Merge setTimeout calls with same timeout for webfont tests.

Landing async stylesheet update caused a regression in font-display
tests. The values "fallback" and "optional" block display for 100ms
according to the spec. The tests had a setTimeout call to trigger font
loading and a setTimeout call to trigger notifyDone() to render before
100ms has passed with the same timeout value. However, the timer for
allowing fallback display triggers before the notifyDone triggers in
Debug builds on Mac. Calling notifyDone from the same setTimeout
callback as triggering font loading.

The intention of the test is to trigger the screen dump when 0s has
passed, so this should be OK. I have not identified what exactly changed
with the async stylesheet patch and why the timeout methods are
interleaved with the timeout for enabling fallback rendering.

Removing one of the other tests or one of the font-display values from
the test array also makes the "fallback" and "optional" start passing
without this change, so there is clearly a timing issue here.

BUG=567021

Review-Url: https://codereview.chromium.org/2584473002
==========

[commit-bot: I haz the power, 2016-12-16 04:53:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 04:55:37]

Description was changed from

==========
Merge setTimeout calls with same timeout for webfont tests.

Landing async stylesheet update caused a regression in font-display
tests. The values "fallback" and "optional" block display for 100ms
according to the spec. The tests had a setTimeout call to trigger font
loading and a setTimeout call to trigger notifyDone() to render before
100ms has passed with the same timeout value. However, the timer for
allowing fallback display triggers before the notifyDone triggers in
Debug builds on Mac. Calling notifyDone from the same setTimeout
callback as triggering font loading.

The intention of the test is to trigger the screen dump when 0s has
passed, so this should be OK. I have not identified what exactly changed
with the async stylesheet patch and why the timeout methods are
interleaved with the timeout for enabling fallback rendering.

Removing one of the other tests or one of the font-display values from
the test array also makes the "fallback" and "optional" start passing
without this change, so there is clearly a timing issue here.

BUG=567021

Review-Url: https://codereview.chromium.org/2584473002
==========

to

==========
Merge setTimeout calls with same timeout for webfont tests.

Landing async stylesheet update caused a regression in font-display
tests. The values "fallback" and "optional" block display for 100ms
according to the spec. The tests had a setTimeout call to trigger font
loading and a setTimeout call to trigger notifyDone() to render before
100ms has passed with the same timeout value. However, the timer for
allowing fallback display triggers before the notifyDone triggers in
Debug builds on Mac. Calling notifyDone from the same setTimeout
callback as triggering font loading.

The intention of the test is to trigger the screen dump when 0s has
passed, so this should be OK. I have not identified what exactly changed
with the async stylesheet patch and why the timeout methods are
interleaved with the timeout for enabling fallback rendering.

Removing one of the other tests or one of the font-display values from
the test array also makes the "fallback" and "optional" start passing
without this change, so there is clearly a timing issue here.

BUG=567021

Committed: https://crrev.com/ad541b1bdc92608984093593d9eb864ad51ed1e6
Cr-Commit-Position: refs/heads/master@{#439026}
==========

[commit-bot: I haz the power, 2016-12-16 04:55:37]

Patchset 1 (id:??) landed as
https://crrev.com/ad541b1bdc92608984093593d9eb864ad51ed1e6
Cr-Commit-Position: refs/heads/master@{#439026}