Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2584453005: Add stopUpdating to ScreenOrientationControllerImpl::frameDestroyed() (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, haraken, mlamouri+watch-blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add stopUpdating to ScreenOrientationControllerImpl::frameDestroyed() When the frame is destroyed, ScreenOrientationController needs to stop updating. BUG= Committed: https://crrev.com/ca6b7f5f1cef70405348de57e3dfec4aae72b6a7 Cr-Commit-Position: refs/heads/master@{#439123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL https://codereview.chromium.org/2568913003/ is hitting a subtle issue and needs some non-trivial remedy, so I split ...
4 years ago (2016-12-16 11:02:53 UTC) #2
mlamouri (slow - plz ping)
lgtm
4 years ago (2016-12-16 14:23:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584453005/1
4 years ago (2016-12-16 14:23:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 16:42:46 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 16:44:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca6b7f5f1cef70405348de57e3dfec4aae72b6a7
Cr-Commit-Position: refs/heads/master@{#439123}

Powered by Google App Engine
This is Rietveld 408576698