Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2584453003: [Android] Stop tearing down the test runner's SIGTERM handler. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
Reviewers:
bpastene, Nico, katthomas
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Stop tearing down the test runner's SIGTERM handler. The test runner was previously tearing down the SIGTERM handler once it finished running tests and generating results. In some cases, though, it's still hanging after that point. This CL keeps the SIGTERM handler through the end of the process s.t. we can still log hangs that happen later. BUG=664308 Committed: https://crrev.com/f3a1be2ad3c26b4bf5639ae435a4f9f3ecf2137d Cr-Commit-Position: refs/heads/master@{#439007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/android/test_runner.py View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
jbudorick
I'm planning to add logging for any live processes in the test runner's process group, ...
4 years ago (2016-12-15 16:57:18 UTC) #2
katthomas
lgtm
4 years ago (2016-12-15 17:55:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584453003/1
4 years ago (2016-12-15 18:02:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357198)
4 years ago (2016-12-15 19:29:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584453003/1
4 years ago (2016-12-16 02:13:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 03:41:35 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3a1be2ad3c26b4bf5639ae435a4f9f3ecf2137d Cr-Commit-Position: refs/heads/master@{#439007}
4 years ago (2016-12-16 03:43:32 UTC) #14
Nico
base_unittests started failing on ClangToTAndroidASan in build https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/4654 with I think a python stack: Traceback ...
4 years ago (2016-12-17 02:45:06 UTC) #16
jbudorick
On 2016/12/17 02:45:06, Nico (out Thu Dec 15) wrote: > base_unittests started failing on ClangToTAndroidASan ...
4 years ago (2016-12-19 16:46:36 UTC) #17
jbudorick
4 years ago (2016-12-19 17:08:14 UTC) #18
Message was sent while issue was closed. 
On 2016/12/19 16:46:36, jbudorick wrote:
> On 2016/12/17 02:45:06, Nico (out Thu Dec 15) wrote:
> > base_unittests started failing on ClangToTAndroidASan in build
> >
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds...
> > with I think a python stack:
> > 
> > Traceback (most recent call last):
> >   File "/b/c/b/ClangToTAndroidASan/src/build/android/test_runner.py", line
> 875,
> > in main
> >     return RunTestsCommand(args)
> >   File "/b/c/b/ClangToTAndroidASan/src/build/android/test_runner.py", line
> 661,
> > in RunTestsCommand
> >     return RunTestsInPlatformMode(args)
> >   File "/b/c/b/ClangToTAndroidASan/src/build/android/test_runner.py", line
> 770,
> > in RunTestsInPlatformMode
> >     raw_results = test_run.RunTests()
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/build/android/pylib/local/device/local_device_test_run.py",
> > line 65, in RunTests
> >     tests = self._GetTests()
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/build/android/pylib/local/device/local_device_gtest_run.py",
> > line 361, in _GetTests
> >     test_lists = self._env.parallel_devices.pMap(list_tests).pGet(None)
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/third_party/catapult/devil/devil/utils/parallelizer.py",
> > line 236, in pMap
> >     r.pFinish(None)
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/third_party/catapult/devil/devil/utils/parallelizer.py",
> > line 135, in pFinish
> >     self._objs.JoinAll()
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/third_party/catapult/devil/devil/utils/reraiser_thread.py",
> > line 186, in JoinAll
> >     self._JoinAll(watcher, timeout)
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/third_party/catapult/devil/devil/utils/reraiser_thread.py",
> > line 158, in _JoinAll
> >     thread.ReraiseIfException()
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/third_party/catapult/devil/devil/utils/reraiser_thread.py",
> > line 81, in run
> >     self._ret = self._func(*self._args, **self._kwargs)
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/build/android/pylib/local/device/local_device_environment.py",
> > line 55, in wrapper
> >     return f(dev, *args, **kwargs)
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/build/android/pylib/local/device/local_device_gtest_run.py",
> > line 352, in list_tests
> >     tests = gtest_test_instance.ParseGTestListTests(raw_test_list)
> >   File
> >
>
"/b/c/b/ClangToTAndroidASan/src/build/android/pylib/gtest/gtest_test_instance.py",
> > line 107, in ParseGTestListTests
> >     test_name = test.split()[0]
> > IndexError: list index out of range
> > 
> > This change is in that build. Do you think that's related?
> 
> I don't think so, but I saw this stack a few times last week on other bots as
> well. I'll look into it.

Looks like this was resolved by https://codereview.chromium.org/2582063002. The
original somehow managed to land with

  TEST(SafeNumerics, )

which then threw off our gtest-list-tests parsing logic.

Powered by Google App Engine
This is Rietveld 408576698