Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2584443003: [Binding] Indent by 2 spaces in generated code. (Closed)

Created:
4 years ago by peria
Modified:
4 years ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Indent by 2 spaces in generated code. generate_indented_conditional() still indented code by 4 spaces. This CL changes to be 2 spaces to follow chromium like style change. BUG=None Committed: https://crrev.com/d88c30689d408397e4ce73795b6ba0da3604644e Cr-Commit-Position: refs/heads/master@{#438800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -295 lines) Patch
M third_party/WebKit/Source/bindings/scripts/code_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 4 chunks +159 lines, -159 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp View 1 chunk +48 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 5 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
peria
PTL. This is a trivial change.
4 years ago (2016-12-15 08:53:42 UTC) #3
Yuki
lgtm
4 years ago (2016-12-15 08:54:53 UTC) #4
haraken
LGTM
4 years ago (2016-12-15 08:55:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584443003/1
4 years ago (2016-12-15 08:55:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 10:43:56 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 10:46:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d88c30689d408397e4ce73795b6ba0da3604644e
Cr-Commit-Position: refs/heads/master@{#438800}

Powered by Google App Engine
This is Rietveld 408576698