Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aa86a5f95ceda02bee65f3b3346611fab9677eef
Cr-Commit-Position: refs/heads/master@{#439006}

[fukino, 2016-12-15 08:18:04]

Description was changed from

==========
Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because
resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
==========

to

==========
Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because
resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-15 08:18:28]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[fukino, 2016-12-15 08:18:28]

PTAL

[oka, 2016-12-15 09:09:57]

https://codereview.chromium.org/2584443002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/volume_manager_util.js (right):

https://codereview.chromium.org/2584443002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/volume_manager_util.js:11: * Time in
milliseconds that we wait a response for. If no response on
response for what?
Don't we update this time too?

[fukino, 2016-12-15 09:51:48]

https://codereview.chromium.org/2584443002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/volume_manager_util.js (right):

https://codereview.chromium.org/2584443002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/volume_manager_util.js:11: * Time in
milliseconds that we wait a response for. If no response on
On 2016/12/15 09:09:57, oka wrote:
> response for what?
> Don't we update this time too?

Updated the comment.
However, I'd keep the time as it is.
It is reasonable for mount/unmount requests.
For requestFileSystem() API calls, I don't see any timeouts in metrics. It
should be OK to use the general timeout period.

[oka, 2016-12-16 01:24:52]

lgtm

[fukino, 2016-12-16 01:36:52]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-12-16 01:36:52]

The CQ bit was unchecked by fukino@chromium.org

[fukino, 2016-12-16 01:36:53]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:38:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:39:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481852213669920,
"parent_rev": "2434b64eacb7b9365222d1b59baf0e0196462d03", "commit_rev":
"ea2d02f90ba6fc1794eb85beda2f770aadca8d4e"}

[commit-bot: I haz the power, 2016-12-16 03:40:10]

Description was changed from

==========
Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because
resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because
resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2584443002
==========

[commit-bot: I haz the power, 2016-12-16 03:40:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 03:43:29]

Description was changed from

==========
Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because
resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2584443002
==========

to

==========
Files app: Make the timeout duration for resolveIsolatedEntries() shorter.

In some feedback reports, users see empty Files app because
resolveIsolatedEntries()
does not finish.
It timeouts in 15 minutes and then Files app should show volumes except for the
erronous volume, but waiting 15 minutes should be too long.
Shorter timeout period should mitigate the issue to some extent.

BUG=671080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aa86a5f95ceda02bee65f3b3346611fab9677eef
Cr-Commit-Position: refs/heads/master@{#439006}
==========

[commit-bot: I haz the power, 2016-12-16 03:43:30]

Patchset 2 (id:??) landed as
https://crrev.com/aa86a5f95ceda02bee65f3b3346611fab9677eef
Cr-Commit-Position: refs/heads/master@{#439006}