Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2584383002: Update comments about active DOM objects (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, tyoshino+watch_chromium.org, szager+layoutwatch_chromium.org, tzik, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, nhiroki, zoltan1, blink-reviews-bindings_chromium.org, jchaffraix+rendering, blink-reviews, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments about active DOM objects ActiveDOMobjects were renamed to SuspendableObjects. This CL updates the comment accordingly. BUG=610176 Committed: https://crrev.com/f5ae60f797bb490fa21fe216453124e79a7017ed Cr-Commit-Position: refs/heads/master@{#439447}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
haraken
PTAL
4 years ago (2016-12-19 08:24:26 UTC) #2
haraken
https://codereview.chromium.org/2584383002/diff/1/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h File third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h (right): https://codereview.chromium.org/2584383002/diff/1/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h#newcode48 third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h:48: class CORE_EXPORT ActiveDOMCallback : public GarbageCollectedMixin { This class ...
4 years ago (2016-12-19 08:24:48 UTC) #3
sof
lgtm
4 years ago (2016-12-19 08:57:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584383002/1
4 years ago (2016-12-19 08:59:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 10:18:11 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 10:21:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5ae60f797bb490fa21fe216453124e79a7017ed
Cr-Commit-Position: refs/heads/master@{#439447}

Powered by Google App Engine
This is Rietveld 408576698