gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)

Committed: https://crrev.com/85cc5d8da31c92572589c5522fd90643be6580d6
Cr-Commit-Position: refs/heads/master@{#439694}

[sadrul, 2016-12-19 06:46:15]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 06:46:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 06:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 06:50:04]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-12-19 07:06:11]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 07:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 08:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 08:02:12]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-19 13:36:39]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 13:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 14:00:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 14:00:44]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sadrul, 2016-12-19 14:25:38]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 14:25:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 15:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 15:16:25]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-19 17:36:02]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-19 17:43:14]

sadrul@chromium.org changed reviewers:
+ jbauman@chromium.org

[sadrul, 2016-12-19 17:43:15]

The follow-up CL to use this from mus clients is at:
https://codereview.chromium.org/2586323002/

jbauman@ please review.

/cc danakj@ FYI

[danakj, 2016-12-19 17:56:43]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-12-19 17:56:43]

I just wanna say I dislike this path
"services/ui/public/cpp/gpu/context_provider_command_buffer.h" as it appears to
be 50% noise, is not easily memorable, and the namespace is ui but this is not
in //ui where other ui:: stuff is.

Conceptually seems okay, and thanks for the FYI :)

[danakj, 2016-12-19 17:57:03]

I just wanna say I dislike this path
"services/ui/public/cpp/gpu/context_provider_command_buffer.h" as it appears to
be 50% noise, is not easily memorable, and the namespace is ui but this is not
in //ui where other ui:: stuff is.

Conceptually seems okay, and thanks for the FYI :)

[sadrul, 2016-12-19 18:02:09]

On 2016/12/19 17:57:03, danakj_OOO_and_slow wrote:
> I just wanna say I dislike this path
> "services/ui/public/cpp/gpu/context_provider_command_buffer.h" as it appears
to
> be 50% noise, is not easily memorable, and the namespace is ui but this is not
> in //ui where other ui:: stuff is.

We are using the 'ui' namespace for all things in services/ui/public/. So this
is sort of unavoidable right now. And the path for public API of various
services also currently look like '//services/<service-name>/public/cpp/...' ...
so that's mostly unavoidable too. But I see your point. Maybe we will come up
with a better naming scheme that would apply to all services at some point?
(e.g. //public/<service-name>/cpp)

> 
> Conceptually seems okay, and thanks for the FYI :)

[commit-bot: I haz the power, 2016-12-19 18:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:40:33]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-12-19 21:54:24]

lgtm, though I agree I'm not a fan of needing to use the ui:: namespace here.

Also one question (inline).

https://codereview.chromium.org/2584363002/diff/80001/services/ui/public/cpp/...
File services/ui/public/cpp/gpu/context_provider_command_buffer.h (right):

https://codereview.chromium.org/2584363002/diff/80001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/context_provider_command_buffer.h:46: class
ContextProviderCommandBuffer
Why don't we need an export here?

[sadrul, 2016-12-20 01:57:21]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2016-12-20 01:57:22]

+jam@ for content/renderer and content/test (will TBR since the code in these
locations are to update for the namespace change)

https://codereview.chromium.org/2584363002/diff/80001/services/ui/public/cpp/...
File services/ui/public/cpp/gpu/context_provider_command_buffer.h (right):

https://codereview.chromium.org/2584363002/diff/80001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/context_provider_command_buffer.h:46: class
ContextProviderCommandBuffer
On 2016/12/19 21:54:23, jbauman wrote:
> Why don't we need an export here?

This is because this belongs in a 'source_set' (as opposed to 'component' for
example)

[sadrul, 2016-12-20 02:13:51]

Description was changed from

==========
gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
==========

to

==========
gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)
==========

[sadrul, 2016-12-20 02:14:09]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-12-20 02:14:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 02:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 02:20:38]

Failed to apply patch for
content/browser/compositor/gpu_process_transport_factory.cc:
While running git apply --index -p1;
  error: patch failed:
content/browser/compositor/gpu_process_transport_factory.cc:48
  error: content/browser/compositor/gpu_process_transport_factory.cc: patch does
not apply

Patch:       content/browser/compositor/gpu_process_transport_factory.cc
Index: content/browser/compositor/gpu_process_transport_factory.cc
diff --git a/content/browser/compositor/gpu_process_transport_factory.cc
b/content/browser/compositor/gpu_process_transport_factory.cc
index
b2d511e37a35816adb72ac5a07beb3e70984330d..7dbc5f5b4385bec6139167583f446366e3dfb586
100644
--- a/content/browser/compositor/gpu_process_transport_factory.cc
+++ b/content/browser/compositor/gpu_process_transport_factory.cc
@@ -39,7 +39,6 @@
 #include "content/browser/gpu/browser_gpu_memory_buffer_manager.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
-#include "content/common/gpu/client/context_provider_command_buffer.h"
 #include "content/common/host_shared_bitmap_manager.h"
 #include "content/public/common/content_switches.h"
 #include "gpu/GLES2/gl2extchromium.h"
@@ -48,6 +47,7 @@
 #include "gpu/command_buffer/common/mailbox.h"
 #include "gpu/ipc/client/gpu_channel_host.h"
 #include "services/service_manager/runner/common/client_util.h"
+#include "services/ui/public/cpp/gpu/context_provider_command_buffer.h"
 #include "third_party/khronos/GLES2/gl2.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/compositor_constants.h"
@@ -105,13 +105,13 @@ bool IsUsingMus() {
   return service_manager::ServiceManagerIsRemote();
 }
 
-scoped_refptr<content::ContextProviderCommandBuffer> CreateContextCommon(
+scoped_refptr<ui::ContextProviderCommandBuffer> CreateContextCommon(
     scoped_refptr<gpu::GpuChannelHost> gpu_channel_host,
     gpu::SurfaceHandle surface_handle,
     bool need_alpha_channel,
     bool support_locking,
-    content::ContextProviderCommandBuffer* shared_context_provider,
-    content::command_buffer_metrics::ContextType type) {
+    ui::ContextProviderCommandBuffer* shared_context_provider,
+    ui::command_buffer_metrics::ContextType type) {
   DCHECK(
      
content::GpuDataManagerImpl::GetInstance()->CanUseGpuBrowserCompositor());
   DCHECK(gpu_channel_host);
@@ -144,7 +144,7 @@ scoped_refptr<content::ContextProviderCommandBuffer>
CreateContextCommon(
   constexpr bool automatic_flushes = false;
 
   GURL url("chrome://gpu/GpuProcessTransportFactory::CreateContextCommon");
-  return make_scoped_refptr(new content::ContextProviderCommandBuffer(
+  return make_scoped_refptr(new ui::ContextProviderCommandBuffer(
       std::move(gpu_channel_host), gpu::GPU_STREAM_DEFAULT,
       gpu::GpuStreamPriority::NORMAL, surface_handle, url, automatic_flushes,
       support_locking, gpu::SharedMemoryLimits(), attributes,
@@ -352,7 +352,7 @@ void GpuProcessTransportFactory::EstablishedGpuChannel(
 
   scoped_refptr<cc::VulkanInProcessContextProvider> vulkan_context_provider =
       SharedVulkanContextProvider();
-  scoped_refptr<ContextProviderCommandBuffer> context_provider;
+  scoped_refptr<ui::ContextProviderCommandBuffer> context_provider;
   if (create_gpu_output_surface && !vulkan_context_provider) {
     // Try to reuse existing worker context provider.
     if (shared_worker_context_provider_) {
@@ -378,10 +378,10 @@ void GpuProcessTransportFactory::EstablishedGpuChannel(
       if (!shared_worker_context_provider_) {
         bool need_alpha_channel = false;
         const bool support_locking = true;
-        shared_worker_context_provider_ =
-            CreateContextCommon(gpu_channel_host, gpu::kNullSurfaceHandle,
-                                need_alpha_channel, support_locking, nullptr,
-                               
command_buffer_metrics::BROWSER_WORKER_CONTEXT);
+        shared_worker_context_provider_ = CreateContextCommon(
+            gpu_channel_host, gpu::kNullSurfaceHandle, need_alpha_channel,
+            support_locking, nullptr,
+            ui::command_buffer_metrics::BROWSER_WORKER_CONTEXT);
         // TODO(vadimt): Remove ScopedTracker below once crbug.com/125248 is
         // fixed. Tracking time in BindToCurrentThread.
         tracked_objects::ScopedTracker tracking_profile(
@@ -408,7 +408,7 @@ void GpuProcessTransportFactory::EstablishedGpuChannel(
         context_provider = CreateContextCommon(
             std::move(gpu_channel_host), surface_handle, need_alpha_channel,
             support_locking, shared_worker_context_provider_.get(),
-            command_buffer_metrics::DISPLAY_COMPOSITOR_ONSCREEN_CONTEXT);
+            ui::command_buffer_metrics::DISPLAY_COMPOSITOR_ONSCREEN_CONTEXT);
         // TODO(vadimt): Remove ScopedTracker below once crbug.com/125248 is
         // fixed. Tracking time in BindToCurrentThread.
         tracked_objects::ScopedTracker tracking_profile(
@@ -828,7 +828,7 @@
GpuProcessTransportFactory::SharedMainThreadContextProvider() {
   shared_main_thread_contexts_ = CreateContextCommon(
       std::move(gpu_channel_host), gpu::kNullSurfaceHandle, need_alpha_channel,
       support_locking, nullptr,
-      command_buffer_metrics::BROWSER_OFFSCREEN_MAINTHREAD_CONTEXT);
+      ui::command_buffer_metrics::BROWSER_OFFSCREEN_MAINTHREAD_CONTEXT);
   shared_main_thread_contexts_->SetLostContextCallback(base::Bind(
       &GpuProcessTransportFactory::OnLostMainThreadSharedContextInsideCallback,
       callback_factory_.GetWeakPtr()));

[sadrul, 2016-12-20 02:22:38]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 02:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-20 02:43:26]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-12-20 02:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2584363002/#ps100001
(title: "tot merge")

[commit-bot: I haz the power, 2016-12-20 02:43:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 03:37:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482201806027730,
"parent_rev": "f183c731b9a7e4064ab61477c631ba004edefc93", "commit_rev":
"1fb04d5fae0c1cd56545b0b6b29370f73d6444cc"}

[commit-bot: I haz the power, 2016-12-20 03:38:10]

Description was changed from

==========
gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)
==========

to

==========
gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)

Review-Url: https://codereview.chromium.org/2584363002
==========

[commit-bot: I haz the power, 2016-12-20 03:38:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-20 03:40:52]

Description was changed from

==========
gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)

Review-Url: https://codereview.chromium.org/2584363002
==========

to

==========
gpu: Move ContextProviderCommandBuffer into mus gpu client-lib.

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)

Committed: https://crrev.com/85cc5d8da31c92572589c5522fd90643be6580d6
Cr-Commit-Position: refs/heads/master@{#439694}
==========

[commit-bot: I haz the power, 2016-12-20 03:40:54]

Patchset 6 (id:??) landed as
https://crrev.com/85cc5d8da31c92572589c5522fd90643be6580d6
Cr-Commit-Position: refs/heads/master@{#439694}