Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2584293002: Coordinator: AppEngine context for Pub/Sub. (Closed)

Created:
4 years ago by dnj
Modified:
4 years ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Coordinator: AppEngine context for Pub/Sub. After switching Pub/Sub to gRPC, we need to pass the AppEngine Context instead of the luci/gae Context. BUG=chromium:675401 TEST=None R=vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2584293002 Committed: https://github.com/luci/luci-go/commit/0da66c1a83109bf1973a7646efec7331bb8f5d41

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M logdog/appengine/coordinator/service.go View 1 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dnj
4 years ago (2016-12-18 21:36:42 UTC) #1
Vadim Sh.
lgtm with nit https://codereview.chromium.org/2584293002/diff/1/logdog/appengine/coordinator/service.go File logdog/appengine/coordinator/service.go (right): https://codereview.chromium.org/2584293002/diff/1/logdog/appengine/coordinator/service.go#newcode346 logdog/appengine/coordinator/service.go:346: // Don't pass gRPC metadata to ...
4 years ago (2016-12-18 21:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584293002/20001
4 years ago (2016-12-18 21:41:18 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-18 21:46:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/0da66c1a83109bf1973a7646efec7331bb8f5d41

Powered by Google App Engine
This is Rietveld 408576698