Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2584223002: [parser] Harden DCHECK into CHECK in parser (Closed)

Created:
4 years ago by Dan Ehrenberg
Modified:
4 years ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Harden DCHECK into CHECK in parser A DCHECK is guarding something which has previously been a memory integrity issue. It should be cheap to run. This patch makes it into a CHECK. BUG=chromium:658267 Review-Url: https://codereview.chromium.org/2584223002 Cr-Commit-Position: refs/heads/master@{#41825} Committed: https://chromium.googlesource.com/v8/v8/+/6cc91d6a1336fdfcdd0e7ffea307dbd506a80a4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/parsing/func-name-inferrer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Ehrenberg
4 years ago (2016-12-18 05:44:26 UTC) #2
marja
lgtm
4 years ago (2016-12-19 09:32:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584223002/1
4 years ago (2016-12-19 21:05:16 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 21:26:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6cc91d6a1336fdfcdd0e7ffea307dbd506a...

Powered by Google App Engine
This is Rietveld 408576698