Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2584193002: Revert of Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
samuong
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delay Input.dispatchKeyEvent response until after key event ack. (patchset #2 id:20001 of https://codereview.chromium.org/2581153003/ ) Reason for revert: This patch makes dispatchMouseEvent not respond for anything except mouse moves. This line is responsible: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/input_router_impl.cc?rcl=1481991563&l=576. Layout test inspector-protocol/input/dispatchMouseEvent.html times out consistently. Original issue's description: > Reland of Delay Input.dispatchKeyEvent response until after key event ack. > > This was originally landed in crrev.com/437706, but was reverted in > crrev.com/437706. This CL contains no changes from the original CL, except that > I've rebased and fixed some merge conflicts. > > BUG=chromedriver:1506 > TBR=pfeldman@chromium.org > > Committed: https://crrev.com/94fba022cb393c5016147649b7145d006c10f264 > Cr-Commit-Position: refs/heads/master@{#439224} TBR=samuong@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromedriver:1506 Committed: https://crrev.com/484ebb7efd9168357ab5ef68fa12089e4e3cb864 Cr-Commit-Position: refs/heads/master@{#439351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -189 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 4 chunks +10 lines, -78 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.h View 5 chunks +4 lines, -23 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 7 chunks +0 lines, -65 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 5 chunks +0 lines, -10 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dgozman
Created Revert of Delay Input.dispatchKeyEvent response until after key event ack.
4 years ago (2016-12-17 20:46:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584193002/1
4 years ago (2016-12-17 20:47:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 20:50:12 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-17 20:52:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/484ebb7efd9168357ab5ef68fa12089e4e3cb864
Cr-Commit-Position: refs/heads/master@{#439351}

Powered by Google App Engine
This is Rietveld 408576698