DevTools: render progress while picking the go-to-file.

DevTools: render progress while picking the go-to-file.

Committed: https://crrev.com/f1f9d506f7afb166feba4cf000aa3a1dc630f8fa
Cr-Commit-Position: refs/heads/master@{#439682}

[pfeldman, 2016-12-17 01:22:28]

pfeldman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[caseq, 2016-12-17 01:28:23]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-12-17 01:28:24]

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:36:
this._progressBarElement = this._progressElement.createChild('div',
'filtered-list-widget-progress-bar');
Any reason to not use <progress> for progress?

[alph, 2016-12-17 01:36:32]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-12-17 01:36:33]

lgtm

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:249:
this._progressBarElement.style.transform = 'scaleX(1)';
just curious why it's better than width?

[lushnikov, 2016-12-19 20:29:46]

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/FilePathScoreFunction.js
(right):

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/FilePathScoreFunction.js:82:
const maxDataLength = 256;
nit: let's use "var" instead of "const"

[alph, 2016-12-19 21:44:13]

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/FilePathScoreFunction.js
(right):

https://codereview.chromium.org/2584113002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/FilePathScoreFunction.js:82:
const maxDataLength = 256;
On 2016/12/19 20:29:46, lushnikov wrote:
> nit: let's use "var" instead of "const" 

Let's use const unless it's a variable, i.e. you reassign its value.

[pfeldman, 2016-12-19 22:43:15]

I believe const-related perf concerns are now resolved, so it is fine to use it.

[pfeldman, 2016-12-20 00:41:23]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:44:46]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-12-20 01:22:47]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-12-20 01:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2584113002/#ps20001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-12-20 01:23:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 02:57:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482196967320170,
"parent_rev": "d66ec7b9a8a0e1c177e449d87032c8dc9026a62e", "commit_rev":
"0154101fe778da62c7134545338ec4dbdf8b9f26"}

[commit-bot: I haz the power, 2016-12-20 02:57:56]

Description was changed from

==========
DevTools: render progress while picking the go-to-file.
==========

to

==========
DevTools: render progress while picking the go-to-file.

Review-Url: https://codereview.chromium.org/2584113002
==========

[commit-bot: I haz the power, 2016-12-20 02:57:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 02:59:49]

Description was changed from

==========
DevTools: render progress while picking the go-to-file.

Review-Url: https://codereview.chromium.org/2584113002
==========

to

==========
DevTools: render progress while picking the go-to-file.

Committed: https://crrev.com/f1f9d506f7afb166feba4cf000aa3a1dc630f8fa
Cr-Commit-Position: refs/heads/master@{#439682}
==========

[commit-bot: I haz the power, 2016-12-20 02:59:50]

Patchset 2 (id:??) landed as
https://crrev.com/f1f9d506f7afb166feba4cf000aa3a1dc630f8fa
Cr-Commit-Position: refs/heads/master@{#439682}