Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2584103002: DevTools: rename default color theme into "Light" (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rename default color theme into "Light" BUG=none R=pfeldman Committed: https://crrev.com/33f87a1a26972442f458cce0a5053c8a6d9dd05d Cr-Commit-Position: refs/heads/master@{#439703}

Patch Set 1 #

Total comments: 1

Patch Set 2 : tags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
lushnikov
please, take a look
4 years ago (2016-12-17 01:06:50 UTC) #1
pfeldman
https://codereview.chromium.org/2584103002/diff/1/third_party/WebKit/Source/devtools/front_end/main/module.json File third_party/WebKit/Source/devtools/front_end/main/module.json (right): https://codereview.chromium.org/2584103002/diff/1/third_party/WebKit/Source/devtools/front_end/main/module.json#newcode268 third_party/WebKit/Source/devtools/front_end/main/module.json:268: { "title": "Switch to light theme", "text": "Light", "value": ...
4 years ago (2016-12-17 01:14:00 UTC) #2
lushnikov
updated! please, take another look
4 years ago (2016-12-17 04:39:38 UTC) #3
pfeldman
lgtm
4 years ago (2016-12-20 00:57:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584103002/20001
4 years ago (2016-12-20 01:15:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 04:19:22 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 04:24:17 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/33f87a1a26972442f458cce0a5053c8a6d9dd05d
Cr-Commit-Position: refs/heads/master@{#439703}

Powered by Google App Engine
This is Rietveld 408576698