Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2584093003:
Temporarily enable PlzNavigate to see perf bot results. (Closed)
DescriptionTemporarily enable PlzNavigate to see perf bot results.
BUG=368813
TBR=clamy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd98556a5beffc0316
Committed: https://crrev.com/722be6f390eba4c47669ad4307d2580dc09762dc
Cr-Commit-Position: refs/heads/master@{#439731}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Temporarily enable PlzNavigate BUG= ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org ==========
jam@chromium.org changed reviewers: + clamy@chromium.org
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org Committed: https://crrev.com/3d001c287618b8298e5b95bd98556a5beffc0316 Cr-Commit-Position: refs/heads/master@{#439350} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3d001c287618b8298e5b95bd98556a5beffc0316 Cr-Commit-Position: refs/heads/master@{#439350}
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org Committed: https://crrev.com/3d001c287618b8298e5b95bd98556a5beffc0316 Cr-Commit-Position: refs/heads/master@{#439350} ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 3d001c287618b8298e5b95bd98556a5beffc0316 (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2584183003/ by jam@chromium.org. The reason for reverting is: Perf bots have started cycling.
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... ==========
Description was changed from ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... ==========
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482216021199370, "parent_rev":
"65db67b88e2a5e66f3a9780f02f816493f298926", "commit_rev":
"7193315c225c53dbe220888587f5961963d58493"}
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... Review-Url: https://codereview.chromium.org/2584093003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... Review-Url: https://codereview.chromium.org/2584093003 ========== to ========== Temporarily enable PlzNavigate to see perf bot results. BUG=368813 TBR=clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd9855... Committed: https://crrev.com/722be6f390eba4c47669ad4307d2580dc09762dc Cr-Commit-Position: refs/heads/master@{#439731} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/722be6f390eba4c47669ad4307d2580dc09762dc Cr-Commit-Position: refs/heads/master@{#439731}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2587333002/ by jam@chromium.org. The reason for reverting is: Change cycled to perf bots..
Message was sent while issue was closed.
On 2016/12/20 07:40:17, jam wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2587333002/ by mailto:jam@chromium.org. > > The reason for reverting is: Change cycled to perf bots.. I think this broke browser_tests and content_browsertests. See https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/33604 . Is that plausible? If so, would it be possible to fix those tests so that testing performance of this patch doesn't kick valid CLs out of the CQ like https://codereview.chromium.org/2594533002/#ps1 ? Thanks.
Message was sent while issue was closed.
On 2016/12/20 08:07:14, Ken Russell wrote: > On 2016/12/20 07:40:17, jam wrote: > > A revert of this CL (patchset #1 id:1) has been created in > > https://codereview.chromium.org/2587333002/ by mailto:jam@chromium.org. > > > > The reason for reverting is: Change cycled to perf bots.. > > I think this broke browser_tests and content_browsertests. See > https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/33604 > . Is that plausible? If so, would it be possible to fix those tests so that > testing performance of this patch doesn't kick valid CLs out of the CQ like > https://codereview.chromium.org/2594533002/#ps1 ? Thanks. Yes there are only a few tests left that have fixes on the way. The CQ shouldn't be impacted with this 1 hour trial, since it'll run failed tests with and without the patch. Did you see otherwise?
Message was sent while issue was closed.
On 2016/12/20 20:34:55, jam wrote: > On 2016/12/20 08:07:14, Ken Russell wrote: > > On 2016/12/20 07:40:17, jam wrote: > > > A revert of this CL (patchset #1 id:1) has been created in > > > https://codereview.chromium.org/2587333002/ by mailto:jam@chromium.org. > > > > > > The reason for reverting is: Change cycled to perf bots.. > > > > I think this broke browser_tests and content_browsertests. See > > > https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/33604 > > . Is that plausible? If so, would it be possible to fix those tests so that > > testing performance of this patch doesn't kick valid CLs out of the CQ like > > https://codereview.chromium.org/2594533002/#ps1 ? Thanks. > > Yes there are only a few tests left that have fixes on the way. The CQ shouldn't > be impacted with this 1 hour trial, since it'll run failed tests with and > without the patch. Did you see otherwise? btw just looked at your patch. The retry without patch is skipped for changes to testing/buildbot/* (otherwise new broken test suites could be added). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
