Prevent timed-out USB transfers from being cancelled twice.

Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012
Committed: https://crrev.com/64539fbea7bd7bbac3933e9413b9502e77633104
Cr-Commit-Position: refs/heads/master@{#439912}

[Reilly Grant (use Gerrit), 2016-12-20 02:57:17]

Description was changed from

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once (they will be changed to
OnceCallbacks in a follow-up patch) and can thus cause issues with
client code.

BUG=675012
==========

to

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012
==========

[Reilly Grant (use Gerrit), 2016-12-20 02:57:17]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-12-20 02:57:18]

Reset callbacks after they are run.

[Reilly Grant (use Gerrit), 2016-12-20 02:57:22]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 02:57:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-12-20 02:57:45]

Description was changed from

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once (they will be changed to
OnceCallbacks in a follow-up patch) and can thus cause issues with
client code.

BUG=675012
==========

to

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012
==========

[Reilly Grant (use Gerrit), 2016-12-20 02:57:45]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-12-20 02:57:54]

Please take a look.

[commit-bot: I haz the power, 2016-12-20 03:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 03:33:25]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-12-20 18:18:54]

https://codereview.chromium.org/2584093002/diff/20001/device/usb/usb_device_h...
File device/usb/usb_device_handle_usbfs.cc (right):

https://codereview.chromium.org/2584093002/diff/20001/device/usb/usb_device_h...
device/usb/usb_device_handle_usbfs.cc:254: TransferCallback callback;
The comment for the above |urb| variable says: "The |urb| field must be the last
in the struct ...", so by moving these three variables after |urb|, it may
affect the overridden new function?

[Reilly Grant (use Gerrit), 2016-12-20 20:28:35]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2016-12-20 20:29:00]

https://codereview.chromium.org/2584093002/diff/20001/device/usb/usb_device_h...
File device/usb/usb_device_handle_usbfs.cc (right):

https://codereview.chromium.org/2584093002/diff/20001/device/usb/usb_device_h...
device/usb/usb_device_handle_usbfs.cc:254: TransferCallback callback;
On 2016/12/20 18:18:54, juncai wrote:
> The comment for the above |urb| variable says: "The |urb| field must be the
last
> in the struct ...", so by moving these three variables after |urb|, it may
> affect the overridden new function?

Done, good catch.

[commit-bot: I haz the power, 2016-12-20 20:29:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-12-20 21:41:20]

LGTM.

[Reilly Grant (use Gerrit), 2016-12-20 22:47:57]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-12-20 22:48:00]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:48:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:09:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482274080178230,
"parent_rev": "34bf74902c5f5e962e444c4aa5f5f421aa9d7bfa", "commit_rev":
"5f6c1d7425be7c0cd76a0e47ad83051d2914a2c7"}

[commit-bot: I haz the power, 2016-12-20 23:09:37]

Description was changed from

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012
==========

to

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012

Review-Url: https://codereview.chromium.org/2584093002
==========

[commit-bot: I haz the power, 2016-12-20 23:09:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 23:12:56]

Description was changed from

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012

Review-Url: https://codereview.chromium.org/2584093002
==========

to

==========
Prevent timed-out USB transfers from being cancelled twice.

If a transfer times out then when the connection is closed the transfer
will be cancelled again. This violates the contract that transfer
callbacks should only be called once and can thus cause issues with
client code.

BUG=675012

Committed: https://crrev.com/64539fbea7bd7bbac3933e9413b9502e77633104
Cr-Commit-Position: refs/heads/master@{#439912}
==========

[commit-bot: I haz the power, 2016-12-20 23:12:57]

Patchset 3 (id:??) landed as
https://crrev.com/64539fbea7bd7bbac3933e9413b9502e77633104
Cr-Commit-Position: refs/heads/master@{#439912}