Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2584023002: Fix PepperVideoDecoderHost to avoid crash when swithing to SW decoder. (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
bbudge
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PepperVideoDecoderHost to avoid crash when swithing to SW decoder. Previously PepperVideoDecoderHost could crash when falling back to software decoder. The problem was that it wasn't handling the case when there is an outstanding texture request for the plugin. Fixed it by dismissing outstanding texture requests when switching to SW decoder. BUG=673452 Committed: https://crrev.com/6f521e723c7536b7656f248273e26a2d4638f6ed Cr-Commit-Position: refs/heads/master@{#439332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M content/renderer/pepper/pepper_video_decoder_host.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
4 years ago (2016-12-16 21:58:37 UTC) #3
bbudge
lgtm
4 years ago (2016-12-17 01:56:00 UTC) #4
Sergey Ulanov
4 years ago (2016-12-17 05:39:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584023002/20001
4 years ago (2016-12-17 05:39:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-17 07:09:42 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-17 07:11:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f521e723c7536b7656f248273e26a2d4638f6ed
Cr-Commit-Position: refs/heads/master@{#439332}

Powered by Google App Engine
This is Rietveld 408576698