Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2583963002: Remove WebUI favicon support on iOS (Closed)

Created:
4 years ago by Jackie Quinn
Modified:
4 years ago
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebUI favicon support on iOS Favicon support for WebUI on iOS was only needed for the history page. Now that history is native on iOS, it is no longer needed. Removing this dead code. BUG=674996 Committed: https://crrev.com/f702287651bbcddad6f6f657696705dfcddb384a Cr-Commit-Position: refs/heads/master@{#439904}

Patch Set 1 #

Patch Set 2 : Remove web_ui_favicons.js from BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -121 lines) Patch
M ios/web/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 4 chunks +1 line, -33 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 1 chunk +0 lines, -30 lines 0 comments Download
M ios/web/webui/resources/web_ui_bundle.js View 1 chunk +0 lines, -1 line 0 comments Download
D ios/web/webui/resources/web_ui_favicons.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Jackie Quinn
4 years ago (2016-12-16 19:14:48 UTC) #2
Eugene But (OOO till 7-30)
lgtm!
4 years ago (2016-12-16 19:19:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583963002/1
4 years ago (2016-12-16 23:30:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/124662) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-16 23:35:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583963002/20001
4 years ago (2016-12-20 19:45:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 22:58:42 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 23:01:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f702287651bbcddad6f6f657696705dfcddb384a
Cr-Commit-Position: refs/heads/master@{#439904}

Powered by Google App Engine
This is Rietveld 408576698