Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2583933002: mus: Add missing dependencies for internal gpu interfaces. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Add missing dependencies for internal gpu interfaces. GpuMain depends on display_compositor in cc, and GpuService depends on gfx and geometry mojoms. BUG=643746 Committed: https://crrev.com/f8a2ae8b13bbef9a8f348759629d9a01fd121169 Cr-Commit-Position: refs/heads/master@{#439162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M services/ui/gpu/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sadrul
4 years ago (2016-12-16 16:54:30 UTC) #4
Fady Samuel
lgtm
4 years ago (2016-12-16 17:02:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583933002/1
4 years ago (2016-12-16 17:13:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 19:15:09 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 19:17:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8a2ae8b13bbef9a8f348759629d9a01fd121169
Cr-Commit-Position: refs/heads/master@{#439162}

Powered by Google App Engine
This is Rietveld 408576698