Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2583913002: Fix webview preloading in zygote. (Closed)

Created:
4 years ago by Torne
Modified:
4 years ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix webview preloading in zygote. We weren't setting the process type, which is fetched via JNI during JNI_OnLoad. Set it by constructing the LibraryLoader singleton, but don't actually call any methods of LibraryLoader, which need to be on the right thread, have a Context, have a CommandLine initialised, and other setup we can't (or at least, don't currently) do in the zygote. BUG= Committed: https://crrev.com/db6be0f685e774c56eef7d03a8ab19736023d8bb Cr-Commit-Position: refs/heads/master@{#439213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Torne
This is the change I think will make a difference (this may not be enough ...
4 years ago (2016-12-16 16:42:06 UTC) #2
Torne
Tested this and it appears to fix the crash on startup. Monochrome works in multiprocess ...
4 years ago (2016-12-16 18:06:09 UTC) #3
Robert Sesek
LGTM. Verified that this fixes the issue we're seeing.
4 years ago (2016-12-16 20:35:31 UTC) #4
Robert Sesek
4 years ago (2016-12-16 21:50:36 UTC) #10
Tobias Sargeant
LGTM
4 years ago (2016-12-16 22:08:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583913002/1
4 years ago (2016-12-16 22:09:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 22:17:36 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db6be0f685e774c56eef7d03a8ab19736023d8bb Cr-Commit-Position: refs/heads/master@{#439213}
4 years ago (2016-12-16 22:19:45 UTC) #18
Tobias Sargeant
4 years ago (2016-12-19 09:40:45 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2586193002/ by tobiasjs@chromium.org.

The reason for reverting is: Realised after the fact that we can't set the
process type because the zygote may spawn renderers for Chrome..

Powered by Google App Engine
This is Rietveld 408576698