Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2583903002: CQ config: remove unused hide_ref_in_committed_msg. (Closed)

Created:
4 years ago by tandrii(chromium)
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CQ config: remove unused hide_ref_in_committed_msg. This has been superseeded by just-in-time determination based on state of gnumbd and git-numberer validation. BUG=644915 R=machenbach@chromium.org,sergiyb@chromium.org NOTRY=True Committed: https://crrev.com/6e3ac8acdc2868d584b150509ba0693b2c090b56 Cr-Commit-Position: refs/heads/master@{#439126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M infra/config/cq.cfg View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
tandrii(chromium)
4 years ago (2016-12-16 15:53:05 UTC) #1
Sergiy Byelozyorov
lgtm this should land only after we disable gnumbd for chromium, right?
4 years ago (2016-12-16 16:38:03 UTC) #6
tandrii(chromium)
On 2016/12/16 16:38:03, Sergiy Byelozyorov wrote: > lgtm > > this should land only after ...
4 years ago (2016-12-16 16:39:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583903002/1
4 years ago (2016-12-16 16:40:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 16:47:42 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 16:49:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e3ac8acdc2868d584b150509ba0693b2c090b56
Cr-Commit-Position: refs/heads/master@{#439126}

Powered by Google App Engine
This is Rietveld 408576698