Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2583843002: Make inner functions less lazy. (Closed)

Created:
4 years ago by marja
Modified:
4 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParsing inner functions: Make inner functions less lazy. Especially, make non-declaration type inner functions eagerly parsed. Then we still have a chance to compile them eagerly if we see () after the function. BUG=v8:5501 Review-Url: https://codereview.chromium.org/2583843002 Cr-Commit-Position: refs/heads/master@{#41762} Committed: https://chromium.googlesource.com/v8/v8/+/f37d726435d3f491dbd193c8c126ebf2252a0212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Toon Verwaest
lgtm
4 years ago (2016-12-16 12:44:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583843002/1
4 years ago (2016-12-16 12:55:40 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-16 13:34:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f37d726435d3f491dbd193c8c126ebf2252...

Powered by Google App Engine
This is Rietveld 408576698