Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2583813002: mb: Add config for new 64 bit android compile on chromium.perf (Closed)

Created:
4 years ago by martiniss
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mb: Add config for new 64 bit android compile on chromium.perf BUG=639530 Committed: https://crrev.com/6971e1458ef6a841163678e915cfa91352ced7ae Cr-Commit-Position: refs/heads/master@{#439254}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
martiniss
PTAL
4 years ago (2016-12-16 08:40:49 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl#newcode329 tools/mb/mb_config.pyl:329: 'Android Compile': 'official_goma_minimal_symbols_android_arm64', Are these backwards?
4 years ago (2016-12-16 16:55:13 UTC) #3
martiniss
https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl#newcode329 tools/mb/mb_config.pyl:329: 'Android Compile': 'official_goma_minimal_symbols_android_arm64', On 2016/12/16 at 16:55:13, Dirk Pranke ...
4 years ago (2016-12-16 18:42:35 UTC) #4
Dirk Pranke
lgtm
4 years ago (2016-12-16 19:06:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583813002/20001
4 years ago (2016-12-16 19:26:57 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years ago (2016-12-16 20:07:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/87867)
4 years ago (2016-12-16 22:11:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583813002/20001
4 years ago (2016-12-16 22:46:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-17 00:39:04 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6971e1458ef6a841163678e915cfa91352ced7ae Cr-Commit-Position: refs/heads/master@{#439254}
4 years ago (2016-12-17 00:42:51 UTC) #17
yoichio
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2582313003/ by yoichio@chromium.org. ...
4 years ago (2016-12-20 02:10:49 UTC) #18
sullivan
4 years ago (2016-12-20 16:49:27 UTC) #19
Message was sent while issue was closed.
On 2016/12/20 02:10:49, yoichio wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2582313003/ by mailto:yoichio@chromium.org.
> 
> The reason for reverting is: This might cause flakiness:
> https://bugs.chromium.org/p/chromium/issues/detail?id=675722.

Note: This was not actually reverted (seems unrelated to that failure)

Powered by Google App Engine
This is Rietveld 408576698