|
|
Chromium Code Reviews
Descriptionmb: Add config for new 64 bit android compile on chromium.perf
BUG=639530
Committed: https://crrev.com/6971e1458ef6a841163678e915cfa91352ced7ae
Cr-Commit-Position: refs/heads/master@{#439254}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixed typo #Messages
Total messages: 19 (7 generated)
martiniss@chromium.org changed reviewers: + dpranke@chromium.org, phajdan.jr@chromium.org, sullivan@chromium.org
PTAL
https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:329: 'Android Compile': 'official_goma_minimal_symbols_android_arm64', Are these backwards?
https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2583813002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:329: 'Android Compile': 'official_goma_minimal_symbols_android_arm64', On 2016/12/16 at 16:55:13, Dirk Pranke wrote: > Are these backwards? Yup. Thanks, fixed.
lgtm
The CQ bit was checked by martiniss@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by martiniss@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481928367988890,
"parent_rev": "28eea2ad94c2c2243e6c09f6c988e592a6ff3a0b", "commit_rev":
"3cfa6c44c75a4fc8e638922f8927e1240091e476"}
Message was sent while issue was closed.
Description was changed from ========== mb: Add config for new 64 bit android compile on chromium.perf BUG=639530 ========== to ========== mb: Add config for new 64 bit android compile on chromium.perf BUG=639530 Review-Url: https://codereview.chromium.org/2583813002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== mb: Add config for new 64 bit android compile on chromium.perf BUG=639530 Review-Url: https://codereview.chromium.org/2583813002 ========== to ========== mb: Add config for new 64 bit android compile on chromium.perf BUG=639530 Committed: https://crrev.com/6971e1458ef6a841163678e915cfa91352ced7ae Cr-Commit-Position: refs/heads/master@{#439254} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6971e1458ef6a841163678e915cfa91352ced7ae Cr-Commit-Position: refs/heads/master@{#439254}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2582313003/ by yoichio@chromium.org. The reason for reverting is: This might cause flakiness: https://bugs.chromium.org/p/chromium/issues/detail?id=675722.
Message was sent while issue was closed.
On 2016/12/20 02:10:49, yoichio wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2582313003/ by mailto:yoichio@chromium.org. > > The reason for reverting is: This might cause flakiness: > https://bugs.chromium.org/p/chromium/issues/detail?id=675722. Note: This was not actually reverted (seems unrelated to that failure) |
