Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences

Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset #1 id:1 of https://codereview.chromium.org/2585543003/ )

Reason for revert:
Relanding this. The real culprit was https://codereview.chromium.org/2578893003/.

Original issue's description:
> Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset #17 id:380001 of https://codereview.chromium.org/2537943002/ )
>
> Reason for revert:
> Suspected cause of ChromiumOS compile failure.
> https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81640
>
> Original issue's description:
> > Getting rid of CompositorFrameMetadata::satisfies_sequences
> >
> > This CL helps unify the way we destroy references to surfaces.
> > We currently have two code paths for satisfying a surface sequence.
> > One is through calling the satisfy callback which is given to the
> > reference holder, and the other one is through populating
> > satisfies_sequences in CompositorFrameMetadata and letting
> > Surface::QueueFrame do the rest of the work. Eventually they both do
> > the same thing: they call SurfaceManager::DidSatisfySequences. This CL
> > gets rid of satisfies_sequences in CompositorFrameMetadata and from now
> > on the only way for satisfying a sequence is through the callback. This
> > is a necessary change because we are phasing out SurfaceSequence and
> > exposing it in CompositorFrameMetadata is not a good idea.
> >
> > BUG=659598
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/d0de6cf72a25d789a507d6eb904a8f1ae314d00b
> > Cr-Commit-Position: refs/heads/master@{#439043}
>
> TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chromium.org,dtrainor@chromium.org,jam@chromium.org,samans@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659598
>
> Committed: https://crrev.com/f0983129357f6a46b29756ed183115b8dc8e371e
> Cr-Commit-Position: refs/heads/master@{#439051}

TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chromium.org,dtrainor@chromium.org,jam@chromium.org,samans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659598
Committed: https://crrev.com/73809d9eebbab0d932cb78ff3618b55a5570cfaf
Cr-Commit-Position: refs/heads/master@{#439064}

[Kunihiko Sakamoto, 2016-12-16 08:02:08]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-12-16 08:02:08]

Created Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences

[commit-bot: I haz the power, 2016-12-16 08:02:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 08:03:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481875328008450, "parent_rev":
"ba5724ca1ac51b6df21de3a529842e6de1b8fe99", "commit_rev":
"f20de3a8d461a1751b7181d7677fe284bc8bd2a1"}

[commit-bot: I haz the power, 2016-12-16 08:03:42]

Description was changed from

==========
Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset
#1 id:1 of https://codereview.chromium.org/2585543003/ )

Reason for revert:
Relanding this. The real culprit was
https://codereview.chromium.org/2578893003/.

Original issue's description:
> Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences
(patchset #17 id:380001 of https://codereview.chromium.org/2537943002/ )
> 
> Reason for revert:
> Suspected cause of ChromiumOS compile failure.
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> Original issue's description:
> > Getting rid of CompositorFrameMetadata::satisfies_sequences
> >
> > This CL helps unify the way we destroy references to surfaces.
> > We currently have two code paths for satisfying a surface sequence.
> > One is through calling the satisfy callback which is given to the
> > reference holder, and the other one is through populating
> > satisfies_sequences in CompositorFrameMetadata and letting
> > Surface::QueueFrame do the rest of the work. Eventually they both do
> > the same thing: they call SurfaceManager::DidSatisfySequences. This CL
> > gets rid of satisfies_sequences in CompositorFrameMetadata and from now
> > on the only way for satisfying a sequence is through the callback. This
> > is a necessary change because we are phasing out SurfaceSequence and
> > exposing it in CompositorFrameMetadata is not a good idea.
> >
> > BUG=659598
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/d0de6cf72a25d789a507d6eb904a8f1ae314d00b
> > Cr-Commit-Position: refs/heads/master@{#439043}
> 
>
TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659598
> 
> Committed: https://crrev.com/f0983129357f6a46b29756ed183115b8dc8e371e
> Cr-Commit-Position: refs/heads/master@{#439051}

TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659598
==========

to

==========
Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset
#1 id:1 of https://codereview.chromium.org/2585543003/ )

Reason for revert:
Relanding this. The real culprit was
https://codereview.chromium.org/2578893003/.

Original issue's description:
> Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences
(patchset #17 id:380001 of https://codereview.chromium.org/2537943002/ )
> 
> Reason for revert:
> Suspected cause of ChromiumOS compile failure.
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> Original issue's description:
> > Getting rid of CompositorFrameMetadata::satisfies_sequences
> >
> > This CL helps unify the way we destroy references to surfaces.
> > We currently have two code paths for satisfying a surface sequence.
> > One is through calling the satisfy callback which is given to the
> > reference holder, and the other one is through populating
> > satisfies_sequences in CompositorFrameMetadata and letting
> > Surface::QueueFrame do the rest of the work. Eventually they both do
> > the same thing: they call SurfaceManager::DidSatisfySequences. This CL
> > gets rid of satisfies_sequences in CompositorFrameMetadata and from now
> > on the only way for satisfying a sequence is through the callback. This
> > is a necessary change because we are phasing out SurfaceSequence and
> > exposing it in CompositorFrameMetadata is not a good idea.
> >
> > BUG=659598
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/d0de6cf72a25d789a507d6eb904a8f1ae314d00b
> > Cr-Commit-Position: refs/heads/master@{#439043}
> 
>
TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659598
> 
> Committed: https://crrev.com/f0983129357f6a46b29756ed183115b8dc8e371e
> Cr-Commit-Position: refs/heads/master@{#439051}

TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659598

Review-Url: https://codereview.chromium.org/2583803002
==========

[commit-bot: I haz the power, 2016-12-16 08:03:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 08:09:07]

Description was changed from

==========
Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset
#1 id:1 of https://codereview.chromium.org/2585543003/ )

Reason for revert:
Relanding this. The real culprit was
https://codereview.chromium.org/2578893003/.

Original issue's description:
> Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences
(patchset #17 id:380001 of https://codereview.chromium.org/2537943002/ )
> 
> Reason for revert:
> Suspected cause of ChromiumOS compile failure.
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> Original issue's description:
> > Getting rid of CompositorFrameMetadata::satisfies_sequences
> >
> > This CL helps unify the way we destroy references to surfaces.
> > We currently have two code paths for satisfying a surface sequence.
> > One is through calling the satisfy callback which is given to the
> > reference holder, and the other one is through populating
> > satisfies_sequences in CompositorFrameMetadata and letting
> > Surface::QueueFrame do the rest of the work. Eventually they both do
> > the same thing: they call SurfaceManager::DidSatisfySequences. This CL
> > gets rid of satisfies_sequences in CompositorFrameMetadata and from now
> > on the only way for satisfying a sequence is through the callback. This
> > is a necessary change because we are phasing out SurfaceSequence and
> > exposing it in CompositorFrameMetadata is not a good idea.
> >
> > BUG=659598
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/d0de6cf72a25d789a507d6eb904a8f1ae314d00b
> > Cr-Commit-Position: refs/heads/master@{#439043}
> 
>
TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659598
> 
> Committed: https://crrev.com/f0983129357f6a46b29756ed183115b8dc8e371e
> Cr-Commit-Position: refs/heads/master@{#439051}

TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659598

Review-Url: https://codereview.chromium.org/2583803002
==========

to

==========
Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset
#1 id:1 of https://codereview.chromium.org/2585543003/ )

Reason for revert:
Relanding this. The real culprit was
https://codereview.chromium.org/2578893003/.

Original issue's description:
> Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences
(patchset #17 id:380001 of https://codereview.chromium.org/2537943002/ )
>
> Reason for revert:
> Suspected cause of ChromiumOS compile failure.
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Original issue's description:
> > Getting rid of CompositorFrameMetadata::satisfies_sequences
> >
> > This CL helps unify the way we destroy references to surfaces.
> > We currently have two code paths for satisfying a surface sequence.
> > One is through calling the satisfy callback which is given to the
> > reference holder, and the other one is through populating
> > satisfies_sequences in CompositorFrameMetadata and letting
> > Surface::QueueFrame do the rest of the work. Eventually they both do
> > the same thing: they call SurfaceManager::DidSatisfySequences. This CL
> > gets rid of satisfies_sequences in CompositorFrameMetadata and from now
> > on the only way for satisfying a sequence is through the callback. This
> > is a necessary change because we are phasing out SurfaceSequence and
> > exposing it in CompositorFrameMetadata is not a good idea.
> >
> > BUG=659598
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/d0de6cf72a25d789a507d6eb904a8f1ae314d00b
> > Cr-Commit-Position: refs/heads/master@{#439043}
>
>
TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659598
>
> Committed: https://crrev.com/f0983129357f6a46b29756ed183115b8dc8e371e
> Cr-Commit-Position: refs/heads/master@{#439051}

TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659598

Committed: https://crrev.com/73809d9eebbab0d932cb78ff3618b55a5570cfaf
Cr-Commit-Position: refs/heads/master@{#439064}
==========

[commit-bot: I haz the power, 2016-12-16 08:09:11]

Patchset 1 (id:??) landed as
https://crrev.com/73809d9eebbab0d932cb78ff3618b55a5570cfaf
Cr-Commit-Position: refs/heads/master@{#439064}