Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2583753002:
[promises] Use TF_BUILTIN (Closed)
Description[promises] Use TF_BUILTIN
BUG=v8:5343
Review-Url: https://codereview.chromium.org/2583753002
Cr-Commit-Position: refs/heads/master@{#41770}
Committed: https://chromium.googlesource.com/v8/v8/+/3f5a60ac17dc1e84bfda6429cc69f7497ed3ea24
Patch Set 1 #Patch Set 2 : Remove var #Patch Set 3 : rebase #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gsathya@chromium.org changed reviewers: + ishell@chromium.org, jgruber@chromium.org
lgtm
Nice, lgtm
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30830)
The CQ bit was checked by gsathya@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org, jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2583753002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481902158090030,
"parent_rev": "8341b8baf44d194f6477abac2c741132b5d314c3", "commit_rev":
"3f5a60ac17dc1e84bfda6429cc69f7497ed3ea24"}
Message was sent while issue was closed.
Description was changed from ========== [promises] Use TF_BUILTIN BUG=v8:5343 ========== to ========== [promises] Use TF_BUILTIN BUG=v8:5343 Review-Url: https://codereview.chromium.org/2583753002 Cr-Commit-Position: refs/heads/master@{#41770} Committed: https://chromium.googlesource.com/v8/v8/+/3f5a60ac17dc1e84bfda6429cc69f7497ed... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/3f5a60ac17dc1e84bfda6429cc69f7497ed... |
