Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2583743002: Add mac-only "Set Up Automatic Updates..." button to the new about page. (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
dpapad
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, mac-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, scottchen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mac-only "Set Up Automatic Updates..." button to the new about page. A mac-only "Set Up Automatic Updates for All Users" button existed in the old crome://help page, but was not ported over to the chrome://md-settings/help page. This CL aims to port that button over. By Scott Chen <scottchen@chromium.org>; (http://crrev.com/2538013002) BUG=649187 TBR=dpapad@chromium.org (LG'd on other CL) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2 Cr-Commit-Position: refs/heads/master@{#439368}

Patch Set 1 #

Patch Set 2 : add back nullptr check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -19 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/mac/keystone_glue.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 3 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 3 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page_browser_proxy.js View 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_mac.mm View 1 chunk +13 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.cc View 1 2 chunks +22 lines, -14 lines 0 comments Download
M chrome/test/data/webui/settings/about_page_tests.js View 1 3 chunks +111 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Dan Beam
4 years ago (2016-12-18 00:20:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583743002/80001
4 years ago (2016-12-18 07:14:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years ago (2016-12-18 07:24:39 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-18 07:26:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2
Cr-Commit-Position: refs/heads/master@{#439368}

Powered by Google App Engine
This is Rietveld 408576698