Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2583733002: Add functionality to window.history.go test page. (Closed)

Created:
4 years ago by kkhorimoto
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add functionality to window.history.go test page. - Added back/forward buttons. - Added pushState() button. This is necessary because if the pushState call is executed by injected JavaScript, then the navigation is registered as a client redirect. - Display placeholder state object string when a popstate event with a null state object is received. BUG=673022 Committed: https://crrev.com/97c65878672508dea30c898fab48c40d36491589 Cr-Commit-Position: refs/heads/master@{#439020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M ios/testing/data/http_server_files/history_go.html View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/testing/data/http_server_files/history_go.js View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kkhorimoto
4 years ago (2016-12-16 01:28:27 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-16 01:45:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583733002/1
4 years ago (2016-12-16 02:22:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 04:19:30 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 04:22:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97c65878672508dea30c898fab48c40d36491589
Cr-Commit-Position: refs/heads/master@{#439020}

Powered by Google App Engine
This is Rietveld 408576698