[Ignition] Teach CompileLazy about interpreted functions.

[Ignition] Teach CompileLazy about interpreted functions.

Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This means
if the SFI has bytecode we have to go through to the runtime to install the
interpreter entry trampoline into the JSFunction object.

Modify the builtin to always put the SFI code object into the JSFunction unless it's
the lazy compile stub on the SFI as well.

BUG=v8:4380
Review-Url: https://codereview.chromium.org/2583693003
Cr-Commit-Position: refs/heads/master@{#42034}
Committed: https://chromium.googlesource.com/v8/v8/+/72c370767226cf573d316655b1d3e3d3d699cc9b

[rmcilroy, 2016-12-16 08:22:47]

Description was changed from

==========
[Ignition] Make CompileLazy builtin know about interpreted functions.

Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This
means
if the SFI has bytecode we have to go through to the runtime to install the
interpreter entry trampoline into the JSFunction object.

Modify the builtin to always put the SFI code object into the JSFunction unless
it's
the lazy compile stub on the SFI as well.

BUG=v8:4380
==========

to

==========
[Ignition] Teach CompileLazy about interpreted functions.

Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This
means
if the SFI has bytecode we have to go through to the runtime to install the
interpreter entry trampoline into the JSFunction object.

Modify the builtin to always put the SFI code object into the JSFunction unless
it's
the lazy compile stub on the SFI as well.

BUG=v8:4380
==========

[rmcilroy, 2016-12-16 08:23:45]

rmcilroy@chromium.org changed reviewers:
+ mvstanton@chromium.org

[rmcilroy, 2016-12-16 08:23:45]

Michael, without this change we were ending up spending more time in CompileLazy
runtime function than we were actually compiling bytecode for the Octane
benchmark I was looking at in Ignition+Turbo. PTAL, thanks.

[mvstanton, 2016-12-16 09:38:05]

That looks good - upload the ports and I'll have a second look! :)

[rmcilroy, 2016-12-16 23:49:37]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 23:49:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-12-16 23:49:51]

On 2016/12/16 09:38:05, mvstanton wrote:
> That looks good - upload the ports and I'll have a second look! :)

Done, PTAL.

[commit-bot: I haz the power, 2016-12-16 23:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:51:15]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18008)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17974)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19711)

[rmcilroy, 2016-12-16 23:55:20]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 23:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 23:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:57:35]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17975)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14406)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19712)

[rmcilroy, 2016-12-17 12:43:57]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 12:44:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 13:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 13:02:42]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18075)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[mvstanton, 2016-12-20 10:55:38]

It looks like you have a corner-case kind of issue.
But the approach is sound: lgtm.

[rmcilroy, 2017-01-03 12:44:13]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 12:44:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 13:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 13:34:02]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[rmcilroy, 2017-01-03 14:53:53]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2017-01-03 14:53:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2583693003/#ps100001
(title: "Fix arm")

[commit-bot: I haz the power, 2017-01-03 14:54:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-01-03 14:54:03]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-01-03 15:18:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483455233988330,
"parent_rev": "d338b94e869a845a53afd5e057c807ed2e2b3a6f", "commit_rev":
"72c370767226cf573d316655b1d3e3d3d699cc9b"}

[commit-bot: I haz the power, 2017-01-03 15:18:30]

Description was changed from

==========
[Ignition] Teach CompileLazy about interpreted functions.

Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This
means
if the SFI has bytecode we have to go through to the runtime to install the
interpreter entry trampoline into the JSFunction object.

Modify the builtin to always put the SFI code object into the JSFunction unless
it's
the lazy compile stub on the SFI as well.

BUG=v8:4380
==========

to

==========
[Ignition] Teach CompileLazy about interpreted functions.

Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This
means
if the SFI has bytecode we have to go through to the runtime to install the
interpreter entry trampoline into the JSFunction object.

Modify the builtin to always put the SFI code object into the JSFunction unless
it's
the lazy compile stub on the SFI as well.

BUG=v8:4380

Review-Url: https://codereview.chromium.org/2583693003
Cr-Commit-Position: refs/heads/master@{#42034}
Committed:
https://chromium.googlesource.com/v8/v8/+/72c370767226cf573d316655b1d3e3d3d69...
==========

[commit-bot: I haz the power, 2017-01-03 15:18:31]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/72c370767226cf573d316655b1d3e3d3d69...