Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2583693002: Allow legacy supervised users to login with invalid oath tokens. (Closed)

Created:
4 years ago by Alexander Alekseev
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Allow legacy supervised users to login with invalid oath tokens. Currently we force online login for legacy supervised users when the oauth token becomes invalid. However there is no online login for legacy supervised users - we just print a cryptic error message, and there is no way to refresh this oauth token, so the account is effectively locked. BUG=chromium:659788 TEST=manual Review-Url: https://codereview.chromium.org/2563573002 Cr-Commit-Position: refs/heads/master@{#438786} (cherry picked from commit 9b57da68302423b74d098c015c97dfe7c9c94ba6) Committed: https://chromium.googlesource.com/chromium/src/+/b1cdc3f6a193cb841dff5dfbb15bd73342665606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexander Alekseev
4 years ago (2016-12-15 22:47:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1cdc3f6a193cb841dff5dfbb15bd73342665606.

Powered by Google App Engine
This is Rietveld 408576698