Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2563573002:
Allow legacy supervised users to login with invalid oath tokens. (Closed)
|
Created:
4 years ago by achuithb Modified:
4 years ago Reviewers:
Alexander Alekseev CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow legacy supervised users to login with invalid oath tokens.
Currently we force online login for legacy supervised users when the oauth
token becomes invalid. However there is no online login for legacy supervised
users - we just print a cryptic error message, and there is no way to refresh
this oauth token, so the account is effectively locked.
BUG=chromium:659788
TEST=manual
Committed: https://crrev.com/9b57da68302423b74d098c015c97dfe7c9c94ba6
Cr-Commit-Position: refs/heads/master@{#438786}
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
achuith@chromium.org changed reviewers: + alemate@chromium.org
Alex, PTAL
The CQ bit was checked by alemate@chromium.org
lgtm
The CQ bit was checked by alemate@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481791342948720, "parent_rev":
"911c8aa1defc429a3705ed6691088ea1268d0b29", "commit_rev":
"c8e73edbf82a563e16340440b995852861fb918a"}
Message was sent while issue was closed.
Description was changed from ========== Allow legacy supervised users to login with invalid oath tokens. Currently we force online login for legacy supervised users when the oauth token becomes invalid. However there is no online login for legacy supervised users - we just print a cryptic error message, and there is no way to refresh this oauth token, so the account is effectively locked. BUG=chromium:659788 TEST=manual ========== to ========== Allow legacy supervised users to login with invalid oath tokens. Currently we force online login for legacy supervised users when the oauth token becomes invalid. However there is no online login for legacy supervised users - we just print a cryptic error message, and there is no way to refresh this oauth token, so the account is effectively locked. BUG=chromium:659788 TEST=manual Review-Url: https://codereview.chromium.org/2563573002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Allow legacy supervised users to login with invalid oath tokens. Currently we force online login for legacy supervised users when the oauth token becomes invalid. However there is no online login for legacy supervised users - we just print a cryptic error message, and there is no way to refresh this oauth token, so the account is effectively locked. BUG=chromium:659788 TEST=manual Review-Url: https://codereview.chromium.org/2563573002 ========== to ========== Allow legacy supervised users to login with invalid oath tokens. Currently we force online login for legacy supervised users when the oauth token becomes invalid. However there is no online login for legacy supervised users - we just print a cryptic error message, and there is no way to refresh this oauth token, so the account is effectively locked. BUG=chromium:659788 TEST=manual Committed: https://crrev.com/9b57da68302423b74d098c015c97dfe7c9c94ba6 Cr-Commit-Position: refs/heads/master@{#438786} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9b57da68302423b74d098c015c97dfe7c9c94ba6 Cr-Commit-Position: refs/heads/master@{#438786} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
