Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2583683004: Disable EarlGrey web shell tests that fail on device. (Closed)

Created:
4 years ago by baxley
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable EarlGrey web shell tests that fail on device. 7 tests, at least some of which use context menus, are failing when run on devices. BUG=675015 Committed: https://crrev.com/3784517e283e6964d9061b0efb5065f8aa3438ec Cr-Commit-Position: refs/heads/master@{#439179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
M ios/web/shell/test/context_menu_egtest.mm View 4 chunks +34 lines, -4 lines 0 comments Download
M ios/web/shell/test/navigation_egtest.mm View 2 chunks +16 lines, -2 lines 0 comments Download
M ios/web/shell/test/page_state_egtest.mm View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
baxley
4 years ago (2016-12-16 19:43:04 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-16 19:48:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583683004/1
4 years ago (2016-12-16 19:52:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 20:48:50 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 20:51:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3784517e283e6964d9061b0efb5065f8aa3438ec
Cr-Commit-Position: refs/heads/master@{#439179}

Powered by Google App Engine
This is Rietveld 408576698