Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2583683002: Add a command ID for opening the Physical Web settings view (Closed)

Created:
4 years ago by mattreynolds
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a command ID for opening the Physical Web settings view BUG=630769 Committed: https://crrev.com/2bfe7389d737a61b169fd54e2c4f3cdf5b290289 Cr-Commit-Position: refs/heads/master@{#439164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mattreynolds
Hi Mark, PTAL
4 years ago (2016-12-15 22:33:30 UTC) #2
marq (ping after 24h)
LGTM
4 years ago (2016-12-16 07:41:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583683002/1
4 years ago (2016-12-16 18:04:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 19:20:46 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 19:23:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bfe7389d737a61b169fd54e2c4f3cdf5b290289
Cr-Commit-Position: refs/heads/master@{#439164}

Powered by Google App Engine
This is Rietveld 408576698