Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2583653002: Log WebAudio context buffer sizes on Android (Closed)

Created:
4 years ago by Raymond Toy
Modified:
4 years ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log WebAudio context buffer sizes on Android It's hard to get the recommended and actual buffer sizes used for the AudioDestination node on Android because there's such a huge range of devices. Log this information so that a simple "adb logcat" can retrieve the relevant sizes. BUG=674703 TEST=none Committed: https://crrev.com/df4781c2f2f090d53d54e2c2b159ae2b0168f7f0 Cr-Commit-Position: refs/heads/master@{#439552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Raymond Toy
PTAL.
4 years ago (2016-12-15 21:36:49 UTC) #3
hongchan
lgtm
4 years ago (2016-12-19 18:27:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583653002/1
4 years ago (2016-12-19 18:32:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 21:04:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 21:07:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df4781c2f2f090d53d54e2c2b159ae2b0168f7f0
Cr-Commit-Position: refs/heads/master@{#439552}

Powered by Google App Engine
This is Rietveld 408576698