Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2583593003: cros: Various fixes needed for preloading lock screen. (Closed)

Created:
4 years ago by jdufault
Modified:
3 years, 11 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Various fixes needed for preloading lock screen. - Test would fail because chrome::NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST was not sent before profile destruction - Locking the screen and then idling for 8 seconds could cause preload which caused DCHECK in shared_web_view to trigger BUG=612271 Committed: https://crrev.com/a0f1cece148ab1d940f840a4ca84fd4c9f9b4e26 Cr-Commit-Position: refs/heads/master@{#441192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/shared_web_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/shared_web_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc View 1 chunk +15 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
jdufault
xiyuan@, alemate@, PTAL. Thanks!
4 years ago (2016-12-15 21:07:20 UTC) #7
xiyuan
lgtm
4 years ago (2016-12-15 21:59:11 UTC) #8
Alexander Alekseev
lgtm
4 years ago (2016-12-21 14:36:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583593003/1
3 years, 11 months ago (2017-01-03 19:18:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 19:56:34 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:58:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f1cece148ab1d940f840a4ca84fd4c9f9b4e26
Cr-Commit-Position: refs/heads/master@{#441192}

Powered by Google App Engine
This is Rietveld 408576698