Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 2583543003: Use more accurate sRGB, Adobe, matrices (Closed)

Created:
4 years ago by msarett
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use more accurate sRGB, Adobe, matrices TBR=fmalita@chromium.org BUG=657839 Committed: https://crrev.com/556786009fd3fdbb395ab09432004a3afbc82b0c Committed: https://crrev.com/7bf60df60dea0a5d295549957e23381898e0af33 Cr-Original-Commit-Position: refs/heads/master@{#439209} Cr-Commit-Position: refs/heads/master@{#440253}

Patch Set 1 #

Patch Set 2 : Add rebaselines #

Patch Set 3 : Remove conflict #

Patch Set 4 : More rebaselines #

Patch Set 5 : More rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -5 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 2 chunks +293 lines, -1 line 0 comments Download

Messages

Total messages: 49 (33 generated)
msarett1
Just doing a dry run so I can find all the tests that I need ...
4 years ago (2016-12-15 21:43:24 UTC) #5
msarett1
Ping. Looks like I don't need to rebaseline :).
4 years ago (2016-12-16 21:41:08 UTC) #8
Brian Osman
lgtm Nice.
4 years ago (2016-12-16 21:42:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583543003/1
4 years ago (2016-12-16 21:49:32 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-16 21:49:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583543003/1
4 years ago (2016-12-16 21:52:19 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-16 21:52:21 UTC) #18
msarett1
On 2016/12/16 21:52:21, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years ago (2016-12-16 21:53:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583543003/1
4 years ago (2016-12-16 21:54:06 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 22:11:00 UTC) #24
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/556786009fd3fdbb395ab09432004a3afbc82b0c Cr-Commit-Position: refs/heads/master@{#439209}
4 years ago (2016-12-16 22:14:34 UTC) #26
rjkroege
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2580153002/ by rjkroege@chromium.org. ...
4 years ago (2016-12-17 00:40:14 UTC) #27
msarett
Thanks, yeah I was expecting to need to do a lot of rebaselines. Not sure ...
4 years ago (2016-12-18 18:28:13 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583543003/80001
4 years ago (2016-12-21 22:49:04 UTC) #44
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-21 22:58:13 UTC) #47
commit-bot: I haz the power
4 years ago (2016-12-21 23:00:01 UTC) #49
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7bf60df60dea0a5d295549957e23381898e0af33
Cr-Commit-Position: refs/heads/master@{#440253}

Powered by Google App Engine
This is Rietveld 408576698