Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2583543002: Revert of [wasm] Make WasmRunner the central test structure (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Make WasmRunner the central test structure (patchset #5 id:80001 of https://codereview.chromium.org/2551043002/ ) Reason for revert: Win64 dbg failures Original issue's description: > [wasm] Make WasmRunner the central test structure > > The WasmRunner now always holds a TestingModule, and allows to add > several functions to it. The prepares a change to always run wasm code > with a full module behind it, removing the special handling for "no wasm > instance" at runtime (http://crrev.com/2551053002). > This CL here also templatizes the WasmRunner such that the Call method must > be called with the same signature specified for the WasmRunner. This > already catched several mismatches there. > > R=titzer@chromium.org, ahaas@chromium.org > BUG=v8:5620 > > Review-Url: https://codereview.chromium.org/2551043002 > Cr-Commit-Position: refs/heads/master@{#41728} > Committed: https://chromium.googlesource.com/v8/v8/+/2ff59062314e9b86bcc28dfaa53cedf2d98e3a13 TBR=ahaas@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5620 Review-Url: https://codereview.chromium.org/2583543002 Cr-Commit-Position: refs/heads/master@{#41732} Committed: https://chromium.googlesource.com/v8/v8/+/5993a1161b3bd2e602c98c6dc675b830cd4fab8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1433 lines, -1093 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 135 chunks +525 lines, -427 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 79 chunks +200 lines, -137 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-asmjs.cc View 13 chunks +100 lines, -79 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 14 chunks +37 lines, -19 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 8 chunks +48 lines, -36 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-relocation.cc View 1 chunk +15 lines, -13 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd-lowering.cc View 13 chunks +74 lines, -70 lines 0 comments Download
M test/cctest/wasm/test-wasm-stack.cc View 4 chunks +25 lines, -19 lines 0 comments Download
M test/cctest/wasm/test-wasm-trap-position.cc View 3 chunks +22 lines, -19 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 18 chunks +380 lines, -270 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Clemens Hammacher
Created Revert of [wasm] Make WasmRunner the central test structure
4 years ago (2016-12-15 16:47:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583543002/1
4 years ago (2016-12-15 16:47:24 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-15 16:47:25 UTC) #5
ahaas
lgtm
4 years ago (2016-12-15 16:50:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583543002/1
4 years ago (2016-12-15 16:51:02 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 16:51:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5993a1161b3bd2e602c98c6dc675b830cd4...

Powered by Google App Engine
This is Rietveld 408576698