Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2583533002: Add msarda@ as owner for most of the signin code. (Closed)

Created:
4 years ago by msarda
Modified:
4 years ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add msarda@ as owner for most of the signin code. This CL adds msarda@ as owner for the most of the sign-in code as his team owns now the Chrome sign-in feature in Chromium. BUG=NONE Committed: https://crrev.com/cd103f305061182cf7b6d5802d9cdb1be2be48f4 Cr-Commit-Position: refs/heads/master@{#439070}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/signin/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarda
Roger: Please take a look.
4 years ago (2016-12-15 16:19:41 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm Who would have though such a simple CL would generate so many comments :-) ...
4 years ago (2016-12-15 17:57:55 UTC) #3
msarda
https://codereview.chromium.org/2583533002/diff/1/chrome/browser/signin/OWNERS File chrome/browser/signin/OWNERS (right): https://codereview.chromium.org/2583533002/diff/1/chrome/browser/signin/OWNERS#newcode1 chrome/browser/signin/OWNERS:1: atwilson@chromium.org On 2016/12/15 17:57:55, Roger Tawa wrote: > Should ...
4 years ago (2016-12-16 08:44:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583533002/20001
4 years ago (2016-12-16 08:45:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 09:00:01 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 09:02:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd103f305061182cf7b6d5802d9cdb1be2be48f4
Cr-Commit-Position: refs/heads/master@{#439070}

Powered by Google App Engine
This is Rietveld 408576698