Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2583523002: Add a comment to IsInitialized() to discourage devs to call it (Closed)

Created:
4 years ago by Yusuke Sato
Modified:
4 years ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment to IsInitialized() to discourage devs to call it BUG=672829 TEST=try Committed: https://crrev.com/f2d8f704cfba6d76429dd9b15169ce2f3cc1fad9 Cr-Commit-Position: refs/heads/master@{#438983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/arc/arc_service_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Yusuke Sato
We should nuke this asap, but for now, I'd add the comment. WDYT? Please have ...
4 years ago (2016-12-15 18:24:34 UTC) #4
hidehiko
lgtm
4 years ago (2016-12-16 01:06:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583523002/1
4 years ago (2016-12-16 01:09:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 01:57:53 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-16 01:59:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2d8f704cfba6d76429dd9b15169ce2f3cc1fad9
Cr-Commit-Position: refs/heads/master@{#438983}

Powered by Google App Engine
This is Rietveld 408576698